Closed ChrisWeissmann closed 2 weeks ago
@shankari can we close https://github.com/EVerest/everest-demo/pull/53 in favor of this PR? Hoping we can merge this soon!
Thank you guys for getting this over to us. I took some time to try out the new demo script and almost everything worked as expected. Here are the steps I took and the results I saw.
git clone https://github.com/ChrisWeissmann/everest-demo.git
git checkout -b feature/add-citrine-support-signedoff origin/feature/add-citrine-support-signedoff
bash demo-iso15118-2-ac-plus-ocpp.sh -2 -c -r $(pwd) -b feature/add-citrine-support-signedoff
BootNotificationResponse
returned accepted ✅setChargingProfile
API request.
Not Implemented
. ✅2024-06-17 22:49:02.926657 [INFO] token_provider_ :: Publishing new dummy token: {"id_token":{"value":"DEADBEEF","type":"ISO14443"},"authorization_type":"RFID","prevalidated":false,"connectors":[1]}
2024-06-17 22:49:02.931590 [INFO] auth:Auth :: Received new token: {
"authorization_type": "RFID",
"connectors": [
1
],
"id_token": {
"type": "ISO14443",
"value": "DEADBEEF"
},
"prevalidated": false
}
2024-06-17 22:49:02.942580 [INFO] ocpp:OCPP201 :: Found invalid entry in AuthCache: Sending new request
2024-06-17 22:49:03.076192 [INFO] auth:Auth :: Result for token: DEADBEEF: REJECTED
Let me know if I did something wrong somewhere along the line that would get 5 working. Other than that one issue, it all looked great. We really appreciate all the work that was put into getting this PR together!
EDIT:
I forgot to check this before, but MaEVe doesn't work with this new script. There are a few changes that need to be made to make it work in this new script, all of which I am working on getting into the review.
@thanaParis @ChrisWeissmann please see comment from @louisg1337
@louisg1337 the issues with maeve have been fixed! the add-charger.sh script was expanded to add-charger-and-rfid-card.sh and now adds an idToken to CitrineOS with value 'DEADBEEF' and type 'ISO14443'.
@louisg1337 in the absence of github actions, can you please try to rerun this for both MaEVe and Citrine? I can then merge this. @mukuflash03 for an example of what the lack of GH actions is doing 😦
@louisg1337 the issues with maeve have been fixed! the add-charger.sh script was expanded to add-charger-and-rfid-card.sh and now adds an idToken to CitrineOS with value 'DEADBEEF' and type 'ISO14443'.
I can confirm everything works as expected now. I tested both Citrine and MaEVe and they both posted Accepted
and worked in the SIL demo. Thank you @thanaParis and @ChrisWeissmann for fixing that for us!
feat: add general citrine support with own device-model. Run bash command with argument
-c
.Testing done: Used local branch to test before pushing to remote
./demo-iso15118-2-ac-plus-ocpp.sh -2 -c -r $(pwd) -b feature/add-citrine-support-signedoff
Adding charger successfully: