search

EVerest / everest-demo

EVerest demo: Dockerized demo with software in the loop simulation
Apache License 2.0
14 stars 15 forks source link

Improvements to the manager Dockerfile #8

Closed drmrd closed 10 months ago

drmrd commented 10 months ago

This small PR updates the Dockerfile for the EVerest manager image to abide by more maintainable practices, including

The size of the image is practically unchanged by this PR, with a roughly 13 MB reduction in total size on the 3.35 GB image.

shankari commented 10 months ago

Since the builds have passed, I am merging this, but I'm not sure where the images have been stored. They were clearly pushed somewhere

#9 exporting to image
#9 exporting layers
#9 exporting layers 9.9s done
#9 writing image sha256:3b6fee69518c951c9d7636af7f2fd9c27031f610c14cf8b9659dba4cae5e45a9 done
#9 naming to ghcr.io/us-joet/everest-demo/manager:pr-8 done
#9 DONE 9.9s

But I would not expect them to be in the US-JOET org since they were built by a workflow running here. And indeed, the images in US-JOET were last updated at the end of Oct.

Screen Shot 2023-12-03 at 11 59 36 PM

@hikinggrass can you see if they are in the everest org, but currently marked as private? Note that packages are initially published as private by default https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility#configuring-visibility-of-packages-for-an-organization

Alternatively, maybe github accepted them first and then discarded them because the org did not match the token. I would expect them to report the failure, though - it is bad practice to fail silently.

This is not super important because we will be rebuilding with the correct org in https://github.com/EVerest/everest-demo/pull/10 but I am curious about what happens in this case 😄