search

EVerest / everest-dev-environment

Useful tools for developing EVerest
Apache License 2.0
12 stars 15 forks source link

[node-red-node-ui-table] Node module cannot be loaded on this version. Requires: >=3.0.0 #49

Closed kellycampbell closed 1 month ago

kellycampbell commented 1 month ago

I get this warning when trying to run the simulator as described at https://everest.github.io/nightly/general/03_quick_start_guide.html#software-in-a-loop and the UI doesn't load properly.

[info] Node-RED version: v2.2.3
[info] Node.js  version: v14.19.3
[info] Linux 6.11.0-8-generic x64 LE
[info] Loading palette nodes
[warn] [node-red-node-ui-table] Node module cannot be loaded on this version. Requires: >=3.0.0 
[info] Dashboard version 3.6.5 started at /ui

I tried updating the Dockerfile to use the latest node-red:4.0.3 and it seems to work fine but not sure if this would cause other issues elsewhere. Pinning node-red-node-ui-table@0.4.3 also works.

andistorm commented 1 month ago

Thanks for your first contribution @kellycampbell!🎉 And also thanks for pointing this issue out.

The Dockerfile in everest-core will be removed with https://github.com/EVerest/everest-core/pull/816, so could be your PR is deprecated after merging this one..

I could reproduce the issue and tried your fix, it works!

I would agree on staying with node-red:2.2.3 at the moment.

I think it would make sense to pin the version of all extensions to prevent such bugs in future, which would be at the moment:

RUN npm install node-red-dashboard@3.6.5
RUN npm install node-red-contrib-ui-actions@0.1.8
RUN npm install node-red-node-ui-table@0.4.3
RUN npm install node-red-contrib-ui-level@0.1.46

Could you please udpate your PRs?

kellycampbell commented 1 month ago

Updated the PR here. Did you still want me to update the other PR since that file will be going away soon anyway?