Bugfix/75 deprecate openssl 1

AssemblyJohn commented 4 months ago

Describe your changes

Removed code calls to Openssl 1.1. Updated CMAKE to have a minimum version of OpenSSL 3.

Closes: https://github.com/EVerest/libevse-security/issues/75 https://github.com/EVerest/libevse-security/issues/38

Issue ticket number and link

https://github.com/EVerest/libevse-security/issues/75 https://github.com/EVerest/libevse-security/issues/38

Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[ ] I read the contribution documentation and made sure that my changes meet its requirements

AssemblyJohn commented 4 months ago

Updated, all entries mentioning OpenSSL.

barsnick commented 4 months ago

Nice, good for consistency and code clean-up.

I'd like to see some of the (global) Dockerfiles and build instructions updated. I failed to find libssl3, even as PPA, for Debian 11 and Ubuntu 20.

AssemblyJohn commented 4 months ago

Nice, good for consistency and code clean-up.

I'd like to see some of the (global) Dockerfiles and build instructions updated. I failed to find libssl3, even as PPA, for Debian 11 and Ubuntu 20.

For Ubuntu 20 the only option is manual install (from sources). Will have to see for Debian.

barsnick commented 4 months ago

There are still some references to detection of OpenSSL v3, more code which can be reduced:

$ git -C ../libevse-security/ grep -Pnw USING_OPENSSL_3 origin/bugfix/75-deprecate-openssl-1
origin/bugfix/75-deprecate-openssl-1:lib/evse_security/crypto/openssl/openssl_tpm.cpp:8:#define USING_OPENSSL_3 (OPENSSL_VERSION_NUMBER >= 0x30000000L)
origin/bugfix/75-deprecate-openssl-1:lib/evse_security/crypto/openssl/openssl_tpm.cpp:10:#if USING_OPENSSL_3 && defined(USING_TPM2)
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:20:#define USING_OPENSSL_3 (OPENSSL_VERSION_NUMBER >= 0x30000000L)
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:22:#if USING_OPENSSL_3
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:52:#endif // USING_OPENSSL_3
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:72:#if USING_OPENSSL_3
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:125:#endif // USING_OPENSSL_3

AssemblyJohn commented 4 months ago

Extra dependencies removed.

EVerest / libevse-security