EWC-consortium / eudi-wallet-rfcs

EU Digital Identity Wallet RFCs in EWC to align towards the Large Scale Pilot (LSP) usecases. The project is co-funded by the European Union.
https://eudiwalletconsortium.org/
Apache License 2.0
15 stars 11 forks source link

Credential Offer credentials field is not matching the OID4VCI Draft 12 #7

Closed ntsbs closed 4 months ago

ntsbs commented 4 months ago

The credential offer response in rfc001 is not compatible with the referenced version of the OID4VCI spec.

The credentials field should be an

An array of unique strings that each identify one of the keys in the name/value pairs stored in the credentials_supported Credential Issuer metadata property. OID4VCI Draft 12 Section 4.1.1

The non-normative example from the spec is as follows:

{
   "credential_issuer": "https://credential-issuer.example.com",
   "credentials": [
      "UniversityDegreeCredential",
      "org.iso.18013.5.1.mDL"
   ],
   "grants": {
      "authorization_code": {
         "issuer_state": "eyJhbGciOiJSU0Et...FYUaBy"
      },
      "urn:ietf:params:oauth:grant-type:pre-authorized_code": {
         "pre-authorized_code": "adhjhdjajkdkhjhdj",
         "user_pin_required": true
      }
   }
}
lalc commented 4 months ago

This change is accepted. The earlier version was coming from EBSI conformant wallet implementation specs.