search

EWSoftware / VSSpellChecker

A Visual Studio spell checker editor extension that checks the spelling of comments, strings, and plain text as you type. Supports configuration and various languages.
Other
376 stars 65 forks source link

Excluding string literals in SQL files (.sql) #147

Closed NoelAbrahams closed 6 years ago

NoelAbrahams commented 6 years ago

Hi,

Version: 2017.8.26.1

We would like comments to be checked in SQL files but we have a number of data insert statements that are being flagged up:

image

Under C# Options in the config, I've set "Ignore normal string literals" to yes, and also the "Apply the above options to all C-style languages as applicable" to yes.

These options do not seem to apply in this context.

Can .sql files be included?

EWSoftware commented 6 years ago

For C# and other C-style languages a separate tagger is used that parses the code based on the expected syntax. It wouldn't work for SQL since it would see the single quote as the start of a single character literal rather than a string literal and wouldn't know about the '--' style of SQL comments among other things.

Everything else goes through a common tagger that looks for common classifications to determine what gets spell checked. I could add a check there based on the SQL content type since I've already got two other options in there for HTML and XML comment exclusions. However, adding more such checks in the future would make the code more cumbersome so I'm inclined to alter how that works and come up with a more generic solution if possible.

I'll take a look into it and see if I can come up with something.

EWSoftware commented 6 years ago

This will be in the next release due out in a week or so. It can be configured through the new Ignored Classifications category of configuration properties.

Makeshet commented 6 years ago

Dear Eric

Thanks you so much.

This will make me so happy!!!!

Eliezer

On Mon, Aug 20, 2018 at 4:12 AM, Eric Woodruff notifications@github.com wrote:

This will be in the next release due out in a week or so. It can be configured through the new Ignored Classifications category of configuration properties.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EWSoftware/VSSpellChecker/issues/147#issuecomment-414171820, or mute the thread https://github.com/notifications/unsubscribe-auth/AAehtw4u_16-7POp2BUvBuyWP_d_vZMnks5uSgz3gaJpZM4Q9dQC .

-- בברכה, דר' אליעזר קפלנסקי מנכ"ל מקשת מערכות מידע בע"מ Makeshet Information Systems LTD