search

EWSoftware / VSSpellChecker

A Visual Studio spell checker editor extension that checks the spelling of comments, strings, and plain text as you type. Supports configuration and various languages.
Other
376 stars 65 forks source link

Fatal crash after invoking a "go to implementation" operation in VS #207

Closed Dave-Lowndes closed 4 years ago

Dave-Lowndes commented 4 years ago

I originally submitted this as a bug report against Visual Studio (16.5 preview 2) as I thought it was a clear bug in the IDE. However I shortly afterwards found that the problem didn't reproduce when I disabled this extension. MS have suggested that I report the issue here, so this is my bug report to MS which contained information gathered by the VS problem reporting tool when I submitted the issue.

While browsing code, I’d used the VS IDE's “go to implementation” facility a few times without an issue, but when I use it in this specific situation, VS just disappears.

I can currently reproduce this each time I’ve tried.

Event log shows:

Application: devenv.exe Framework Version: v4.0.30319 Description: The application requested process termination through System.Environment.FailFast(string message). Stack: at EnvDTE.SolutionClass.FindProjectItem(System.String) at VisualStudio.SpellChecker.Utility.FindProjectItemForFile(EnvDTE.Solution, System.String) at VisualStudio.SpellChecker.SpellingServiceFactory.GenerateConfiguration(Microsoft.VisualStudio.Text.ITextBuffer) at VisualStudio.SpellChecker.SpellingServiceFactory.GetConfiguration(Microsoft.VisualStudio.Text.ITextBuffer) at VisualStudio.SpellChecker.SpellingServiceFactory.GetDictionary(Microsoft.VisualStudio.Text.ITextBuffer) at VisualStudio.SpellChecker.SuggestedActions.SpellSuggestedActionSource+SpellSmartTaggerProvider.CreateSuggestedActionsSource(Microsoft.VisualStudio.Text.Editor.ITextView, Microsoft.VisualStudio.Text.ITextBuffer) at Microsoft.VisualStudio.Language.Intellisense.Implementation.LightBulbBroker+<>cDisplayClass50_0.b0(Microsoft.VisualStudio.Language.Intellisense.ISuggestedActionsSourceProvider) at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.InvokeMatchingFactories[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Collections.Generic.IEnumerable1<System.Lazy2<System.Canon,System.Canon>>, System.Func2<System.Canon,System.Canon>, Microsoft.VisualStudio.Utilities.IContentType, System.Object) at Microsoft.VisualStudio.Language.Intellisense.Implementation.LightBulbBroker.CreateSourcesForBuffer(Microsoft.VisualStudio.Text.Editor.ITextView, Microsoft.VisualStudio.Text.ITextBuffer) at Microsoft.VisualStudio.Language.Intellisense.Implementation.LightBulbBroker+<>c__DisplayClass45_0.b0(Microsoft.VisualStudio.Text.ITextBuffer) at Microsoft.VisualStudio.Language.Utilities.IntellisenseSourceCache+ViewSourceCache1[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].GetSources(System.Collections.Generic.IEnumerable1) at Microsoft.VisualStudio.Language.Utilities.IntellisenseSourceCache.GetSources[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](Microsoft.VisualStudio.Text.Editor.ITextView, Microsoft.VisualStudio.Text.ITextBuffer, System.Func2<Microsoft.VisualStudio.Text.ITextBuffer,System.Collections.Generic.IReadOnlyCollection1>) at Microsoft.VisualStudio.Language.Intellisense.Implementation.LightBulbBroker.GetSuggestedActionsSources(Microsoft.VisualStudio.Text.Editor.ITextView, Microsoft.VisualStudio.Text.ITextBuffer) at Microsoft.VisualStudio.Language.Intellisense.Implementation.LightBulbController+d29.MoveNext() at Microsoft.VisualStudio.Language.Intellisense.Implementation.LightBulbController.ConnectSubjectBuffer(Microsoft.VisualStudio.Text.ITextBuffer) at Microsoft.VisualStudio.Language.Intellisense.Implementation.LightBulbController..ctor(Microsoft.VisualStudio.Text.Editor.IWpfTextView, System.Collections.Generic.IList1, Microsoft.VisualStudio.Language.Intellisense.Implementation.TestHooks.IAsynchronousOperationListener, Microsoft.VisualStudio.Language.Intellisense.Implementation.DefaultLightBulbControllerProvider) at Microsoft.VisualStudio.Language.Intellisense.Implementation.DefaultLightBulbControllerProvider.TryCreateIntellisenseController(Microsoft.VisualStudio.Text.Editor.ITextView, System.Collections.Generic.IList1) at Microsoft.VisualStudio.Language.Intellisense.Implementation.IntellisenseManagerConnectionListener+<>cDisplayClass8_1.b1(Microsoft.VisualStudio.Language.Intellisense.IIntellisenseControllerProvider) at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.InstantiateExtension[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Object, System.Lazy2<System.Canon,System.Canon>, System.Func2<System.Canon,System.Canon>) at Microsoft.VisualStudio.Language.Intellisense.Implementation.IntellisenseManagerConnectionListener.SubjectBuffersConnected(Microsoft.VisualStudio.Text.Editor.ITextView, Microsoft.VisualStudio.Text.Editor.ConnectionReason, System.Collections.Generic.IReadOnlyCollection1) at Microsoft.VisualStudio.Text.Editor.Implementation.ConnectionManager+NonWpfListener.SubjectBuffersConnected(Microsoft.VisualStudio.Text.Editor.IWpfTextView, Microsoft.VisualStudio.Text.Editor.ConnectionReason, System.Collections.ObjectModel.Collection1) at Microsoft.VisualStudio.Text.Editor.Implementation.ConnectionManager+<>cDisplayClass7_3.<.ctor>b__3() at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.CallExtensionPoint(System.Object, System.Action) at Microsoft.VisualStudio.Text.Editor.Implementation.ConnectionManager..ctor(Microsoft.VisualStudio.Text.Editor.IWpfTextView, System.Collections.Generic.ICollection1<System.Lazy2<Microsoft.VisualStudio.Text.Editor.IWpfTextViewConnectionListener,Microsoft.VisualStudio.Text.Utilities.IContentTypeAndTextViewRoleMetadata>>, System.Collections.Generic.ICollection1<System.Lazy2<Microsoft.VisualStudio.Text.Editor.ITextViewConnectionListener,Microsoft.VisualStudio.Text.Utilities.IContentTypeAndTextViewRoleMetadata>>, Microsoft.VisualStudio.Text.Utilities.GuardedOperations) at Microsoft.VisualStudio.Text.Editor.Implementation.WpfTextView.Initialize() at Microsoft.VisualStudio.Text.Editor.Implementation.WpfTextEditorFactoryService.InitializeTextView(Microsoft.VisualStudio.Text.Editor.IWpfTextView) at Microsoft.VisualStudio.Editor.Implementation.SimpleTextViewWindow.Init_InitializeWpfTextView() at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindowPane.b40_0(Microsoft.VisualStudio.Text.Differencing.IDifferenceTextViewModel, Microsoft.VisualStudio.Text.Editor.ITextViewRoleSet, Microsoft.VisualStudio.Text.Editor.IEditorOptions, System.Windows.FrameworkElement ByRef, Microsoft.VisualStudio.Text.Editor.IWpfTextViewHost ByRef) at Microsoft.VisualStudio.Text.Differencing.Implementation.DifferenceViewer.EnsureRightHost() at Microsoft.VisualStudio.Text.Differencing.Implementation.DifferenceViewer.GetHostForViewMode(DifferenceViewMode2) at Microsoft.VisualStudio.Text.Differencing.Implementation.DifferenceViewer.UpdateVisual(Boolean) at Microsoft.VisualStudio.Text.Differencing.Implementation.DifferenceViewer.Initialize(Microsoft.VisualStudio.Text.Differencing.IDifferenceBuffer, Microsoft.VisualStudio.Text.Differencing.CreateTextViewHostCallback, Microsoft.VisualStudio.Text.Editor.IEditorOptions) at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindowPane.InitializeDifferenceViewer() at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindowPane.b33_0() at Microsoft.VisualStudio.Editor.Implementation.SimpleTextViewWindow.Init_OnActivation() at Microsoft.VisualStudio.Editor.Implementation.SimpleTextViewWindow.get_WpfTextViewHost() at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindowPane.OnLayoutUpdated(System.Object, System.EventArgs) at System.Windows.ContextLayoutManager.fireLayoutUpdateEvent() at System.Windows.ContextLayoutManager.UpdateLayout() at System.Windows.UIElement.UpdateLayout() at System.Windows.Controls.TabItem.OnPreviewGotKeyboardFocus(System.Windows.Input.KeyboardFocusChangedEventArgs) at System.Windows.UIElement.OnPreviewGotKeyboardFocusThunk(System.Object, System.Windows.Input.KeyboardFocusChangedEventArgs) at System.Windows.Input.KeyboardFocusChangedEventArgs.InvokeEventHandler(System.Delegate, System.Object) at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object) at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs) at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean) at System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject, System.Windows.RoutedEventArgs) at System.Windows.UIElement.RaiseTrustedEvent(System.Windows.RoutedEventArgs) at System.Windows.UIElement.RaiseEvent(System.Windows.RoutedEventArgs, Boolean) at System.Windows.Input.InputManager.ProcessStagingArea() at System.Windows.Input.InputManager.ProcessInput(System.Windows.Input.InputEventArgs) at System.Windows.Input.KeyboardDevice.TryChangeFocus(System.Windows.DependencyObject, System.Windows.Input.IKeyboardInputProvider, Boolean, Boolean, Boolean) at System.Windows.Input.KeyboardDevice.Focus(System.Windows.DependencyObject, Boolean, Boolean, Boolean) at System.Windows.Input.KeyboardDevice.Focus(System.Windows.IInputElement) at System.Windows.UIElement.Focus() at System.Windows.Controls.TabItem.SetFocus() at System.Windows.Controls.TabControl.OnSelectionChanged(System.Windows.Controls.SelectionChangedEventArgs) at Microsoft.VisualStudio.PlatformUI.LayoutSynchronizedTabControl.OnSelectionChanged(System.Windows.Controls.SelectionChangedEventArgs) at System.Windows.Controls.Primitives.Selector.InvokeSelectionChanged(System.Collections.Generic.List1, System.Collections.Generic.List1) at System.Windows.Controls.Primitives.Selector+SelectionChanger.End() at System.Windows.Controls.Primitives.Selector+SelectionChanger.SelectJustThisItem(ItemInfo, Boolean) at System.Windows.Controls.Primitives.Selector.OnSelectedItemChanged(System.Windows.DependencyObject, System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.OnPropertyChanged(System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.FrameworkElement.OnPropertyChanged(System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.NotifyPropertyChange(System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.UpdateEffectiveValue(System.Windows.EntryIndex, System.Windows.DependencyProperty, System.Windows.PropertyMetadata, System.Windows.EffectiveValueEntry, System.Windows.EffectiveValueEntry ByRef, Boolean, Boolean, System.Windows.OperationType) at System.Windows.DependencyObject.InvalidateProperty(System.Windows.DependencyProperty, Boolean) at System.Windows.Data.BindingExpressionBase.Invalidate(Boolean) at System.Windows.Data.BindingExpression.TransferValue(System.Object, Boolean) at System.Windows.Data.BindingExpression.ScheduleTransfer(Boolean) at MS.Internal.Data.ClrBindingWorker.NewValueAvailable(Boolean, Boolean, Boolean) at MS.Internal.Data.PropertyPathWorker.UpdateSourceValueState(Int32, System.ComponentModel.ICollectionView, System.Object, Boolean) at MS.Internal.Data.PropertyPathWorker.OnDependencyPropertyChanged(System.Windows.DependencyObject, System.Windows.DependencyProperty, Boolean) at MS.Internal.Data.ClrBindingWorker.OnSourceInvalidation(System.Windows.DependencyObject, System.Windows.DependencyProperty, Boolean) at System.Windows.Data.BindingExpression.HandlePropertyInvalidation(System.Windows.DependencyObject, System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.Data.BindingExpressionBase.OnPropertyInvalidation(System.Windows.DependencyObject, System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.Data.BindingExpression.OnPropertyInvalidation(System.Windows.DependencyObject, System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependentList.InvalidateDependents(System.Windows.DependencyObject, System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.NotifyPropertyChange(System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.UpdateEffectiveValue(System.Windows.EntryIndex, System.Windows.DependencyProperty, System.Windows.PropertyMetadata, System.Windows.EffectiveValueEntry, System.Windows.EffectiveValueEntry ByRef, Boolean, Boolean, System.Windows.OperationType) at System.Windows.DependencyObject.SetValueCommon(System.Windows.DependencyProperty, System.Object, System.Windows.PropertyMetadata, Boolean, Boolean, System.Windows.OperationType, Boolean) at System.Windows.DependencyObject.SetValue(System.Windows.DependencyProperty, System.Object) at Microsoft.VisualStudio.PlatformUI.Shell.ViewElement.UpdateParentSelectedElement() at Microsoft.VisualStudio.PlatformUI.Shell.View.OnIsSelectedChanged() at Microsoft.VisualStudio.PlatformUI.Shell.ViewElement.OnIsSelectedChanged(System.Windows.DependencyObject, System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.OnPropertyChanged(System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.NotifyPropertyChange(System.Windows.DependencyPropertyChangedEventArgs) at System.Windows.DependencyObject.UpdateEffectiveValue(System.Windows.EntryIndex, System.Windows.DependencyProperty, System.Windows.PropertyMetadata, System.Windows.EffectiveValueEntry, System.Windows.EffectiveValueEntry ByRef, Boolean, Boolean, System.Windows.OperationType) at System.Windows.DependencyObject.SetValueCommon(System.Windows.DependencyProperty, System.Object, System.Windows.PropertyMetadata, Boolean, Boolean, System.Windows.OperationType, Boolean) at System.Windows.DependencyObject.SetValue(System.Windows.DependencyProperty, System.Object) at Microsoft.VisualStudio.PlatformUI.Shell.ViewElement.set_IsSelected(Boolean) at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.ShowInternal(ShowFlags) at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.b504_0() at Microsoft.VisualStudio.ErrorHandler.CallWithCOMConvention(System.Func1, Boolean, Boolean) at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.Show() at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame+MarshalingWindowFrame.b12_0() at Microsoft.VisualStudio.Shell.ThreadHelper.Invoke[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089] at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame+MarshalingWindowFrame.Microsoft.VisualStudio.Shell.Interop.IVsWindowFrame.Show() at Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem.VisualStudioWorkspaceImpl.OpenDocumentCore(Microsoft.CodeAnalysis.DocumentId, Boolean) at Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem.VisualStudioWorkspaceImpl.OpenDocument(Microsoft.CodeAnalysis.DocumentId, Boolean) at Microsoft.VisualStudio.LanguageServices.Implementation.VisualStudioDocumentNavigationService.OpenDocument(Microsoft.CodeAnalysis.Workspace, Microsoft.CodeAnalysis.DocumentId) at Microsoft.VisualStudio.LanguageServices.Implementation.VisualStudioDocumentNavigationService.TryNavigateToSpan(Microsoft.CodeAnalysis.Workspace, Microsoft.CodeAnalysis.DocumentId, Microsoft.CodeAnalysis.Text.TextSpan, Microsoft.CodeAnalysis.Options.OptionSet) at Microsoft.CodeAnalysis.DocumentSpanExtensions.TryNavigateTo(Microsoft.CodeAnalysis.DocumentSpan, Boolean) at Microsoft.CodeAnalysis.FindUsages.DefinitionItem+DefaultDefinitionItem.TryNavigateTo(Microsoft.CodeAnalysis.Workspace, Boolean) at Microsoft.CodeAnalysis.Editor.Host.IStreamingFindUsagesPresenterExtensions+d0.MoveNext() at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1[[System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Start[[Microsoft.CodeAnalysis.Editor.Host.IStreamingFindUsagesPresenterExtensions+d0, Microsoft.CodeAnalysis.EditorFeatures, Version=3.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]](d0 ByRef) at Microsoft.CodeAnalysis.Editor.Host.IStreamingFindUsagesPresenterExtensions.TryNavigateToOrPresentItemsAsync(Microsoft.CodeAnalysis.Editor.Host.IStreamingFindUsagesPresenter, Microsoft.CodeAnalysis.Workspace, System.String, System.Collections.Immutable.ImmutableArray1) at Microsoft.CodeAnalysis.Editor.CommandHandlers.AbstractGoToCommandHandler2[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].StreamingGoTo(Microsoft.CodeAnalysis.Document, Int32, System.Canon, Microsoft.CodeAnalysis.Editor.Host.IStreamingFindUsagesPresenter, System.Threading.CancellationToken, System.String ByRef) at Microsoft.CodeAnalysis.Editor.CommandHandlers.AbstractGoToCommandHandler2[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].ExecuteCommand(Microsoft.CodeAnalysis.Document, Int32, System.Canon, Microsoft.VisualStudio.Commanding.CommandExecutionContext) at Microsoft.CodeAnalysis.Editor.CommandHandlers.AbstractGoToCommandHandler2[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].ExecuteCommand(System.Canon, Microsoft.VisualStudio.Commanding.CommandExecutionContext) at Microsoft.VisualStudio.Commanding.CommandHandlerExtensions.ExecuteCommand[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](Microsoft.VisualStudio.Commanding.ICommandHandler, System.Canon, System.Action, Microsoft.VisualStudio.Commanding.CommandExecutionContext) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService+<>c__DisplayClass13_11[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].b1() at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.CallExtensionPoint(System.Object, System.Action, System.Predicate1) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService+<>cDisplayClass13_11[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].b0() at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.ExecuteCommandHandlerChain(Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerServiceState, System.Action, System.Action) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.Execute[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Func3<Microsoft.VisualStudio.Text.Editor.ITextView,Microsoft.VisualStudio.Text.ITextBuffer,System.Canon>, System.Action) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.ExecuteCustomCommandHelper[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Type, System.Action) at System.RuntimeMethodHandle.InvokeMethod(System.Object, System.Object[], System.Signature, Boolean) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(System.Object, System.Object[], System.Object[]) at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.ExecuteCustomCommand(System.Type, System.Action) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter+<>cDisplayClass23_0.b0() at Microsoft.VisualStudio.Commanding.CommandHandlerExtensions.ExecuteCommand[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](Microsoft.VisualStudio.Commanding.ICommandHandler, System.Canon, System.Action, Microsoft.VisualStudio.Commanding.CommandExecutionContext) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService+<>cDisplayClass13_11[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].b1() at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.CallExtensionPoint(System.Object, System.Action, System.Predicate1) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService+<>cDisplayClass13_11[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].b0() at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.ExecuteCommandHandlerChain(Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerServiceState, System.Action, System.Action) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.Execute[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Func3<Microsoft.VisualStudio.Text.Editor.ITextView,Microsoft.VisualStudio.Text.ITextBuffer,System.Canon>, System.Action) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.ExecuteCustomCommandHelper[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Type, System.Action) at System.RuntimeMethodHandle.InvokeMethod(System.Object, System.Object[], System.Signature, Boolean) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(System.Object, System.Object[], System.Object[]) at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.ExecuteCustomCommand(System.Type, System.Action) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter+<>cDisplayClass23_0.b0() at Microsoft.VisualStudio.Commanding.CommandHandlerExtensions.ExecuteCommand[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](Microsoft.VisualStudio.Commanding.ICommandHandler, System.Canon, System.Action, Microsoft.VisualStudio.Commanding.CommandExecutionContext) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService+<>cDisplayClass13_11[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].b1() at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.CallExtensionPoint(System.Object, System.Action, System.Predicate1) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService+<>c__DisplayClass13_11[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].b0() at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.ExecuteCommandHandlerChain(Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerServiceState, System.Action, System.Action) at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.Execute[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Func3<Microsoft.VisualStudio.Text.Editor.ITextView,Microsoft.VisualStudio.Text.ITextBuffer,System.Canon>, System.Action) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.ExecuteCustomCommandHelper[[System.Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Type, System.Action) at System.RuntimeMethodHandle.InvokeMethod(System.Object, System.Object[], System.Signature, Boolean) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(System.Object, System.Object[], System.Object[]) at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.ExecuteCustomCommand(System.Type, System.Action) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter+<>cDisplayClass23_0.b0() at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.ExecuteCustomCommand(System.Guid ByRef, UInt32, System.Action) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceAdapter.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandHandlerServiceFilter.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.InnerExec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.LanguageServices.Implementation.AbstractOleCommandTarget.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.InnerExec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandFilterWrapper.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.InnerExec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandFilterWrapper.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.InnerExec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.Intellisense.MultiCaretPreemptingFilterProvider+MultiCaretPreemptingFilter.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.InnerExec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.InnerExec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.SimpleTextViewWindow.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Shell.Interop.IVsUIDataSource.Invoke(System.String, System.Object, System.Object ByRef) at Microsoft.Internal.VisualStudio.PlatformUI.DataSource.Invoke(System.String, System.Object, System.Object ByRef) at Microsoft.VisualStudio.PlatformUI.VsCommand.Execute(System.Object) at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(System.Windows.Input.ICommandSource, Boolean) at System.Windows.Controls.MenuItem.InvokeClickAfterRender(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.DispatcherOperation.InvokeImpl() at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object) at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object) at System.Windows.Threading.DispatcherOperation.Invoke() at System.Windows.Threading.Dispatcher.ProcessQueue() at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32) at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr) at Microsoft.VisualStudio.PlatformUI.NativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef) at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService+<>c.b250_1(System.Object, Microsoft.VisualStudio.PlatformUI.OleComponentSupport.PreTranslateMessageEventArgs) at Microsoft.VisualStudio.PlatformUI.OleComponentSupport.OleComponent.FPreTranslateMessageCore(Microsoft.VisualStudio.OLE.Interop.MSG[]) at Microsoft.VisualStudio.PlatformUI.OleComponentSupport.OleComponent+<>cDisplayClass24_0.b__0() at Microsoft.VisualStudio.PlatformUI.OleComponentSupport.OleComponent.CallAndReturnOnException(System.Func1, Int32) at Microsoft.VisualStudio.PlatformUI.OleComponentSupport.OleComponent.Microsoft.VisualStudio.OLE.Interop.IOleComponent.FPreTranslateMessage(Microsoft.VisualStudio.OLE.Interop.MSG[]) at Microsoft.VisualStudio.OLE.Interop.IOleComponentManager.FPushMessageLoop(UInt32, UInt32, IntPtr) at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService.PushMessageLoopOnContextMenuTrackingComponent() at Microsoft.VisualStudio.Shell.Interop.IVsUIShell.ShowContextMenu(UInt32, System.Guid ByRef, Int32, Microsoft.VisualStudio.Shell.Interop.POINTS[], Microsoft.VisualStudio.OLE.Interop.IOleCommandTarget) at Microsoft.VisualStudio.Editor.Implementation.SimpleTextViewWindow.ShowContextMenu(IntPtr, Int32 ByRef) at Microsoft.VisualStudio.Editor.Implementation.SimpleTextViewWindow.InnerExec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr) at Microsoft.VisualStudio.Editor.Implementation.CommandChainNode.Exec(System.Guid ByRef, UInt32, UInt32, IntPtr, IntPtr)

The remainder of the message was truncated.

EWSoftware commented 4 years ago

I don't have the preview installed. Can it be reproduced in the current release (16.4.5)? Also, what steps specifically do you perform in order to trigger the crash?

Dave-Lowndes commented 4 years ago

Hi Eric, I didn't try reproducing it on a released version as I thought it was a VS bug and needed addressing against the latest preview version. Unfortunately several days have passed and I can't immediately remember (or see from the lack of visible attachments to the MS bug I submitted) precisely what I was doing. All I can remember currently is that the code I was back-tracking in (using go to implementation) wound back to code that was generated by NSWAG, and it was attempting to get back to that where the fatal crash occurred. It was only after I'd looked at the event log stack trace that I spotted the spell checker in there and decided to try without it that I found the eventual target code was in NSWAG generated code and didn't directly form part of the solution. I'll try to remember what I was doing and see if I can still repro it.

Dave-Lowndes commented 4 years ago

I've not had this problem occur with the recent 16.5 preview 3, 4, and now 5 versions, though as I mentioned before I've only got a vague memory of what I was doing to reproduce it, rather than the exact steps. If it does reoccur I'll take more detailed notes and get back to you.

EWSoftware commented 4 years ago

16.5 is now live and I have it installed. I wasn't able to reproduce the issue with Go To Implementation so I'm closing this for now. If the issue reoccurs, feel free to reopen the issue and post the steps necessary to reproduce it and I'll look into it.

Dave-Lowndes commented 4 years ago

I've not had it happen subsequently either.