EWSoftware / VSSpellChecker

A Visual Studio spell checker editor extension that checks the spelling of comments, strings, and plain text as you type. Supports configuration and various languages.
Other
377 stars 65 forks source link

Action command buttons #226

Closed walterpg closed 3 years ago

walterpg commented 3 years ago

Hi all, Thanks for this great extension. I enjoy it thoroughly, but I think it could benefit from a few commanding mods. Specifically, in order of importance to me:

For example, using Tools ⇒ Customize, the following is possible with the current extension:

VSSpellChecker Toolbar Yuck

Whereas the changes shown below (highlighted with a yellow rectangle) are much more pleasant for me:

VSSpellChecker Toolbar Yay

The hotkey assignment in the tooltip above is a personal customization shown by VS for free; I recommend that the extension should not define default command hotkeys.

These features are implemented in my fork. A PR is forthcoming.

EWSoftware commented 3 years ago

Thanks for the update. However, I'd rather see the spell check buttons on their own toolbar that can be shown or hidden based on the user's preference rather than presumptively adding them to the text editor toolbar where the user has to take steps to hide them if not wanted. People can be touchy about their toolbar layouts.

Agreed on the hotkeys. A help topic is provided that describes binding them if wanted.

walterpg commented 3 years ago

Cool, thanks again.

On Wed, Feb 10, 2021, 9:34 PM Eric Woodruff notifications@github.com wrote:

Thanks for the update. However, I'd rather see the spell check buttons on their own toolbar that can be shown or hidden based on the user's preference rather than presumptively adding them to the text editor toolbar where the user has to take steps to hide them if not wanted. People can be touchy about their toolbar layouts.

Agreed on the hotkeys. A help topic http://ewsoftware.github.io/VSSpellChecker/html/63d5096c-6695-441d-886a-01a120f2894a.htm is provided that describes binding them if wanted.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EWSoftware/VSSpellChecker/issues/226#issuecomment-777183352, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUEHJFKJ5AVZ753C7O7PHTS6NF2TANCNFSM4XOCJBIQ .

walterpg commented 3 years ago

Thanks for the update. However, I'd rather see the spell check buttons on their own toolbar that can be shown or hidden based on the user's preference rather than presumptively adding them to the text editor toolbar where the user has to take steps to hide them if not wanted. People can be touchy about their toolbar layouts.

Done in the amended #227.

EWSoftware commented 3 years ago

The changes have been merged and will be in the next release due out soon.