[ISSUE#9] Fixed incorrect usage of Boolean class for converting boole…

EXIficient / exificient.js

JavaScript Implementation of EXI and EXI for JSON

21 stars 3 forks source link

Closed BEllis closed 6 years ago

BEllis commented 6 years ago

…an strings into boolean values.

Switched from new Boolean(value) to value == 'true'
Added Unit Test for Issue9
Updated exificient.js and xml-parser.js files with latest changes (used typescript 2.8.3)

BEllis commented 6 years ago

It may be this fix is too simple if the EXI4JSON specification specifies values other than "true" and "false" can be treated as boolean properties.

However, this is certainly an improvement to always encoding boolean values as true.

BEllis commented 6 years ago

It appears this fix should be fine, as RFC 7159 specifies,

A JSON value MUST be an object, array, number, or string, or one of the following three literal names:

false null true