nojomyth-dev commented 6 months ago

Description

This PR fixes the existing issue with the scripting feature of correo (namely cannot load engine / cannot find polyglot / etc). (See attached image for "it works on my machine" proof, was tested beforehand with current develop and issue was verified).

Fixes implementation for #15

[x] Bug Fix (non-breaking change to fix a bug)

How to test

Please describe steps to test your change.

[ ] mvn clean install
[ ] java -jar target/correomqtt-1.0-SNAPSHOT.jar
[ ] (Optional for debug information, that the engine can actually be resolved:) java -jar "-Dpolyglotimpl.TraceClassPathIsolation=true" target/correomqtt-1.0-SNAPSHOT.jar

Requirments: This branch, jdk 17, maven

Plugins: default
Specific broker: ?

Checklist:

[x] Code follows the coding guidelines
[x] Code is understandable by others
[x] Code is commented
[x] Migration of local user data is included (if relevant)
[ ] No unexpected warnings or exceptions are thrown.
[x] Plugin compatibility is checked (if relevant)
[ ] Unit Tests are added

nojomyth-dev commented 6 months ago

It does log a error, regarding a pipe not being connected, however i think this is not related to this fix. Cannot verify / investigate due to lack of knowledge of the project. It does not affect the execution, that still runs fine and prints the result as expected. It does not crash and subsequent attempts also work