EYBlockchain / nightfall_3

a mono-repo containing an optimistic version of nightfall
Creative Commons Zero v1.0 Universal
260 stars 57 forks source link

fix: add salt to challenge #1408

Closed Westlad closed 1 year ago

Westlad commented 1 year ago

What does this implement/fix? Explain your changes.

This is a bug fix. The 'historic root block number not correct' challenge is not salted. This means that if the challenge commitment is front-run, the original challenger would be locked out from sending a new commitment because they could not generate a new commit hash by changing their salt.

Does this close any currently open issues?

No

What commands can I run to test the change?

There is no change to the standard tests.

Any other comments?