search

EYBlockchain / nightfall_3

a mono-repo containing an optimistic version of nightfall
Creative Commons Zero v1.0 Universal
260 stars 57 forks source link

fix: fix loop index in transform circuit #1416

Closed RajeevS17 closed 1 year ago

RajeevS17 commented 1 year ago

What does this implement/fix? Explain your changes.

The part fixed in the transform circuit checks that the commitment values do not overflow. The fix replaces commitmentsValues[0] by commitmentsValues[i] in line 108. As this is input in a loop, it make sense that the commitment values should be checked for every iteration.

Does this close any currently open issues?

What commands can I run to test the change?

npm t

Any other comments?

Westlad commented 1 year ago

Closed as this change is incorporated in #1435