EYBlockchain / nightfall_3

a mono-repo containing an optimistic version of nightfall
Creative Commons Zero v1.0 Universal
263 stars 57 forks source link

fix transaction save #1421

Closed Westlad closed 1 year ago

Westlad commented 1 year ago

What does this implement/fix? Explain your changes.

When a duplicate transaction is received, it can, under certain circumstances, overwrite the earlier example of the duplicate in the database. This results in the duplicate transaction not being detected.

Does this close any currently open issues?

No

What commands can I run to test the change?

Conventional npm test is fine. The logs of the optimist-resync test will now show a correct resync of block 7, which contains the last-created deposit transaction. Previously it did not.

Any other comments?