EYBlockchain / nightfall_3

a mono-repo containing an optimistic version of nightfall
Creative Commons Zero v1.0 Universal
260 stars 57 forks source link

check balance after transfer rollback #1425

Closed druiz0992 closed 1 year ago

druiz0992 commented 1 year ago

What does this implement/fix? Explain your changes.

Expand adversary test coverage to check balances after transfers are rolledback. Expected outcome is that the commitment used for the incorrect transaction is fully available to the user. That is, that the balance before the incorrect transfer is proposed and after the incorrect transfer is rolledback is the same.

Does this close any currently open issues?

What commands can I run to test the change?

Any other comments?

Westlad commented 1 year ago

Closing because we believe this problem only arises for a user who is (deliberately) generating bad transactions. Therefore, it's not something we will fix because we wish to discourage bad behaviour.