search

EYBlockchain / nightfall_3

a mono-repo containing an optimistic version of nightfall
Creative Commons Zero v1.0 Universal
263 stars 57 forks source link

Set ci job timeouts #1442

Open fullkomnun opened 1 year ago

fullkomnun commented 1 year ago

A few suggestions for the ci workflows:

  1. The default time-out for a github ci job is 360m (6h) and unfortunately setting a default time-out at the entire workflow scope is not yet supported so to prevent a job from hanging for so long, it is useful to set a sensible (but not too strict) time-out per job explicitly (specific limits are flexible)
  2. A nice optimization: when triggered due to a PR and new commits are pushed while jobs are still in-progress they will be cancelled in favor of the newly triggered jobs (stopping stale jobs running on invalidated PR)
  3. (optional) Also added 'workflow_dispatch' as a trigger so that workflow can be started manually via web (Actions tab) to anyone who has permissions to do so (will only appear there after PR is merged). Useful for troubleshooting and nicer than empty commits.