Closed codfish closed 4 years ago
iAmMichaelConnor
commented
4 years ago @codfish follow-up question:
I notice there is only a tagged v1.3.0 here: https://hub.docker.com/r/eyblockchain/timber/tags
The latest tag in this repo is v2.0.0. Does that mean a tag of v2.0.0 hasn't been published to https://hub.docker.com/r/eyblockchain/timber/tags? (or is the packaged labelled 'latest' v2.0.0?)
Many thanks!
alexcoury
commented
4 years ago @codfish @ocgordon @alexcoury many thanks for this!
What are the implications of this change for non-EY people wanting to use Timber (or Nightfall, which uses Timber)? We previously had this 'installation' info in the README:
" Github Configuration
In order to use Nightfall, you will need to be logged into the Github package registry. To do this, you will need to generate a Github Personal Access Token. Make sure that the token you generate has at minimum read: packages and repo permissions.
After you've done that, log in to the Github package registry by running
docker login -u <your-username> -p <the-token-you-just-generated> docker.pkg.github.com"Question: Do users still have to create a Github PAT? In particular, are there any extra steps for non-EY users? And should the above README wording be altered at all (or removed entirely)?
@iAmMichaelConnor The Github personal access token is no longer needed now since we are using dockerhub. The README can be updated to remove this section as well.
alexcoury
commented
4 years ago @ocgordon is currently working on updating the README and github actions @iAmMichaelConnor https://github.com/EYBlockchain/nightfall/pull/385/files
github-actions[bot]
commented
4 years ago :tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
@codfish @ocgordon @alexcoury many thanks for this!
What are the implications of this change for non-EY people wanting to use Timber (or Nightfall, which uses Timber)? We previously had this 'installation' info in the README:
" Github Configuration
In order to use Nightfall, you will need to be logged into the Github package registry. To do this, you will need to generate a Github Personal Access Token. Make sure that the token you generate has at minimum read: packages and repo permissions.
After you've done that, log in to the Github package registry by running
docker login -u <your-username> -p <the-token-you-just-generated> docker.pkg.github.com"Question: Do users still have to create a Github PAT? In particular, are there any extra steps for non-EY users? And should the above README wording be altered at all (or removed entirely)?