EYHN / vscode-vibrancy

Enable Acrylic/Glass effect for your VS Code.
MIT License
561 stars 37 forks source link

Visual Studio Code Version 1.56.0 breaks terminal pane transparency #100

Closed mkanet closed 3 years ago

mkanet commented 3 years ago

VSCode 1.56.0 added terminal tabs. This completely broke the transparency effect in the terminal pane. Looks so ugly.

Is there a way to fix this? Screenshot 05-05-2021 at 04 50 37 PM

I had to revert back to the previous VSCode version.

bika-c commented 3 years ago

The original setting "terminal.integrated.rendererType": "dom" is deprecated. Use this instead: "terminal.integrated.gpuAcceleration": "off" Here is the reference

bika-c commented 3 years ago

So, I guess the readme.md will be updated very soon

mkanet commented 3 years ago

Thank you. A couple of questions.

  1. Is "terminal.integrated.gpuAcceleration": "off" exactly the same as "terminal.integrated.rendererType": "dom" in terms of performance and functionality?
  2. I have an VSCode extension that also utilizes Vibrancy code. If I wanted to automatically add the setting "terminal.integrated.gpuAcceleration": "off" to settings.json when my extension installs, can I add the below code to my package.json? If not, how can I do that without having to manually add that setting?
    "configuration": {
    "title": "Vibrancy Effect",
    "properties": {
        "terminal.integrated.gpuAcceleration": {
            "type": "string",
            "default": "off"
        }
    }
    }

    Update: It looks like this is what I needed to change:

extension/index.js

async function changeTerminalRendererType() {
    let v = vscode.workspace.getConfiguration().inspect("terminal.integrated.gpuAcceleration");
    // let v = vscode.workspace.getConfiguration().inspect("terminal.integrated.rendererType");
    if (v !== undefined) {
        if (!v.globalValue) {
            await vscode.workspace.getConfiguration().update("terminal.integrated.gpuAcceleration", "off", vscode.ConfigurationTarget.Global);
            // await vscode.workspace.getConfiguration().update("terminal.integrated.rendererType", "dom", vscode.ConfigurationTarget.Global);
        }
    }
}
'''
Vbner commented 3 years ago

The original setting "terminal.integrated.rendererType": "dom" is deprecated. Use this instead: "terminal.integrated.gpuAcceleration": "off" Here is the reference

Thank you for your help, Appreciate it !!

EYHN commented 3 years ago

Thanks for the heads up guys, I've fixed this in 1.0.15. Please make sure you have upgraded to the latest version.