EYHN / vscode-vibrancy

Enable Acrylic/Glass effect for your VS Code.
MIT License
561 stars 37 forks source link

Resize to smallest window bug in VS Code 1.57 #109

Open IgnusG opened 3 years ago

IgnusG commented 3 years ago

There seems to be something causing VS Code to resize to the smallest window size when dragging by the title bar - so it looks like this:

image

This only happens in 1.57 in both vibrancy 1.0.15 and 1.0.16-rc1 (the latter one does seem to fix #106, #107, #108).

EYHN commented 3 years ago

I can't reproduce this problem on my computer, maybe you can record or describe how to reproduce it.

IgnusG commented 3 years ago

Let me know if any logs of some sort would help.

https://user-images.githubusercontent.com/6438760/122076463-308d8b00-cdfb-11eb-8c8d-874533013a11.mp4

EYHN commented 3 years ago

Thanks for the demo video, I'm sorry there is no such log. I need you to provide your windows 10 system version and if you have software running on your system about mouse or window control, maybe something like autohotkey

IgnusG commented 3 years ago

I'm on 21H1 (Build 19043.1055). It's an almost blank windows installation without anything like autohotkey.

exzenous commented 3 years ago

In my situation, it happens only on non-100% scaling DPI. The problem exists where I drag VS Code window in internal Surface display which has 200% scaling DPI whereas my external display has 100% scaling DPI. I'm running Windows 11 Build 22000.120 with VS Code 1.59.0 Attached video showing 200% scaling and then 100% scaling

https://user-images.githubusercontent.com/33378035/128472251-81be3478-6afd-4981-9868-594818eae52a.mp4

IgnusG commented 3 years ago

I can confirm I do have scaling set to 175%

Shir0ha commented 3 years ago

window.getBounds() mess up on my pc

try remove / electron.screen.getDisplayMatching(basisBounds).scaleFactor at https://github.com/EYHN/vscode-vibrancy/blob/733a07104e6f6666aed228447f88d3c00a88f218/runtime/win10refresh.js#L181 and see if it works

Path here if you don't wanna repack %userprofile%\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vscode-vibrancy-runtime-v6

With the latest VSCode (1.61.2) and Vibrancy (v1.0.16), the folder changed to %userprofile%\.vscode\extensions\eyhn.vscode-vibrancy-1.0.16\runtime

exzenous commented 3 years ago

window.getBounds() mess up on my pc

try remove / electron.screen.getDisplayMatching(basisBounds).scaleFactor at https://github.com/EYHN/vscode-vibrancy/blob/733a07104e6f6666aed228447f88d3c00a88f218/runtime/win10refresh.js#L181 and see if it works

Path here if you don't wanna repack %userprofile%\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vscode-vibrancy-runtime-v6

That works!

https://user-images.githubusercontent.com/33378035/130011967-623f6790-1fa6-428c-91ad-69b9751319ce.mp4

th3jesta commented 2 years ago

This is also happening to me on Windows 11, any build. DPI is set to 300%.