EZ64cool / obs-hadowplay

GNU General Public License v2.0
44 stars 2 forks source link

Out of game save notification sound #19

Open WatislavB opened 5 months ago

WatislavB commented 5 months ago

I use Replay Buffer all the time, even on the desktop, since auto-enabling may not always work, as happened with the game The Finals, due to the fact that it is not captured by game_capture. In addition, I often use the Replay Buffer just on the desktop, but in this case, if obs_hadowplay does not capture the game, it does not play the save notification sound. Wouldn't it be more logical to always play the Replay Buffer save notification sound, regardless of whether obs_hadowplay has detected the game? Or at least it would be possible to make such a setting in the plugin settings window? This would completely replace the obsnotification script for me.

Thank you ❤️

EZ64cool commented 5 months ago

Yeah there's no reason I couldn't allow this Currently it works only when the replay has been "re-organised" into a named folder, but it probably makes more sense to have it play for any save/make it an option.

ipsusu commented 1 month ago

+1 to this, would be awesome. still using a notification script in addition to the plugin right now because i need to know if my clip is saved correctly on games where it doesn't properly switch to my game capture scene (supposed to auto switch when a fullscreen app is focused) and falls back on my desktop capture scene.

perhaps something i can fix but idk how, so this would be very helpful.

WatislavB commented 1 month ago

+1 to this, would be awesome. still using a notification script in addition to the plugin right now because i need to know if my clip is saved correctly on games where it doesn't properly switch to my game capture scene (supposed to auto switch when a fullscreen app is focused) and falls back on my desktop capture scene.

perhaps something i can fix but idk how, so this would be very helpful.

To automatically switch scenes, I use the Advanced Scene Switcher plugin. I created 2 macros that switch the scenes for the game capture and the desktop (the desktop capture scene still needs to have a game capture source to see that the game is running). In the macro conditions, the Window is checked for "Window is fullscreen", "Window is focused" and the Game Capture source is checked for "change". In this case, the macro switches the scene to capture the game without capturing the screen. Likewise, the second macro changes the scene to capture the desktop if I minimize or close the game

![image](https://github.com/user-attachments/assets/f18eed94-3805-41b0-a17c-948a95c65f0c)
![image](https://github.com/user-attachments/assets/90d563e5-216f-41c2-8781-346759904f11)
![image](https://github.com/user-attachments/assets/6a889f7b-bccd-490f-8022-b7b65fe18b32)

However, if the game is not running, but the Replay Buffer is running to record the desktop - I would also like to see notifications when saving

ipsusu commented 1 month ago

yes! i do the exact same, but for whatever reason OBS doesn't detect certain games as fullscreen (possibly due to overlays etc? it's a fullscreen borderless window). even if i make it switch via a hardcoded window name in the macro, the game capture still doesn't work.

perhaps i could have a specific game capture scene for each of these titles i identify, and hardcode it to switch? would make stuff more complicated but oh well...