search

EaTea / OS-glowing-ninja

OS-Project-FunFun
1 stars 1 forks source link

Fix makefile #11

Closed nictheman closed 12 years ago

nictheman commented 12 years ago

Silly thing to ask, but when you get a chance, can you update the makefile so that it runs queue properly? My brain is mush after working Prof Comp all day and I can't work it out. Also, if queue.h includes os-project.h, we don't need to include os-project on any file that includes queue, mirite? or I guess we can use #IFDEF.

I'm sorry, my brain is going crazy. IT's been a crazy day and now I need to go out and warp my mind even further. Probably not a good night to contact me regarding OS, but I should be right tomorrow to talk about it. If you can just clean the makefiles I should be right to go on some OS work tomorrow..

EaTea commented 12 years ago

Thought I'd wait until today to ask (was at a party last night ^^'), I'm not entirely sure what you mean here. You said "run queue properly"; do you want me to move the queue into the main target? Is there something I'm missing? Did you just want to test the queue? If so, running make qtest should work.

You're right with regards to the #include, though we can do that later.

I might be right to work on this later tonight. Sorry about my lack of response. =\

On 6 October 2012 18:11, Nic Barbaro notifications@github.com wrote:

Silly thing to ask, but when you get a chance, can you update the makefile so that it runs queue properly? My brain is mush after working Prof Comp all day and I can't work it out. Also, if queue.h includes os-project.h, we don't need to include os-project on any file that includes queue, mirite? or I guess we can use #IFDEF.

I'm sorry, my brain is going crazy. IT's been a crazy day and now I need to go out and warp my mind even further. Probably not a good night to contact me regarding OS, but I should be right tomorrow to talk about it. If you can just clean the makefiles I should be right to go on some OS work tomorrow..

— Reply to this email directly or view it on GitHubhttps://github.com/EaTea/OS-glowing-ninja/issues/11.

nictheman commented 12 years ago

Yep that's basically what I meant -- I'm done testing the queue, and I want to actually use it in my rr.c file. So it neds to go to the main target I guess, I will do it wrong so I will leave it up to you. Sorry, I also had quite a crazy day and night and my mind is ruined. I've just pushed some include problems to the rr branch. Definitely needs to be fixed up. We really don't have time for this hey, I just did my Prof Comp timetable and we are way overshooting to get stuff done :(

A few late nights at CS after the 19th, ne?

EaTea commented 12 years ago

Prof Comp. That feel.

Re: scheduling, I understand bru, don't worry, my team is in the same position at the moment. Our development is more than a week behind and we're lucky that my test lead is starting to work and we scheduled an extra week in our project.

For now I haven't run into those problems, so I'd like to check that there are no commits that are local to your side and weren't on the repository. Give me an all clear via FB or github and I'll push through two commits, one on test and the other on RR. I'm not sure why you've run into those issues tbh. Quite odd.

On 7 October 2012 15:43, Nic Barbaro notifications@github.com wrote:

Yep that's basically what I meant -- I'm done testing the queue, and I want to actually use it in my rr.c file. So it neds to go to the main target I guess, I will do it wrong so I will leave it up to you. Sorry, I also had quite a crazy day and night and my mind is ruined. I've just pushed some include problems to the rr branch. Definitely needs to be fixed up. I don't have time, I just did my Prof Comp timetable and we are way overshooting to get stuff done :(

— Reply to this email directly or view it on GitHubhttps://github.com/EaTea/OS-glowing-ninja/issues/11#issuecomment-9205968.

EaTea commented 12 years ago

I put a commit into rr. Try giving it a run. It only has a new template file and a small change to the makefile. It appears (not confirmed!) that the problem was just missing the file. Once the file is there, the .o can be generated and the target can be built.

There could be other issues though. Let me know how it goes, since for now on my side it seemed to work.

On 7 October 2012 17:44, Edwin Tay ed.r.tay@gmail.com wrote:

Prof Comp. That feel.

Re: scheduling, I understand bru, don't worry, my team is in the same position at the moment. Our development is more than a week behind and we're lucky that my test lead is starting to work and we scheduled an extra week in our project.

For now I haven't run into those problems, so I'd like to check that there are no commits that are local to your side and weren't on the repository. Give me an all clear via FB or github and I'll push through two commits, one on test and the other on RR. I'm not sure why you've run into those issues tbh. Quite odd.

On 7 October 2012 15:43, Nic Barbaro notifications@github.com wrote:

Yep that's basically what I meant -- I'm done testing the queue, and I want to actually use it in my rr.c file. So it neds to go to the main target I guess, I will do it wrong so I will leave it up to you. Sorry, I also had quite a crazy day and night and my mind is ruined. I've just pushed some include problems to the rr branch. Definitely needs to be fixed up. I don't have time, I just did my Prof Comp timetable and we are way overshooting to get stuff done :(

— Reply to this email directly or view it on GitHubhttps://github.com/EaTea/OS-glowing-ninja/issues/11#issuecomment-9205968.