EagerELK / ditty

Sinatra Based Web Application Framework
MIT License
8 stars 7 forks source link

Add rubocop to the Travis build and resolve all W errors and higher #5

Closed jrgns closed 7 years ago

jrgns commented 7 years ago

Add the following command to the travis build, before the specs run:

bundle exec rubocop --fail-level W lib views

Ensure that the build passes by fixing all W and higher errors.

Atul9 commented 7 years ago

I would like to take this up.

Atul9 commented 7 years ago

I tried to fix few of the warnings from rubocop. - https://travis-ci.org/Atul9/ditty/jobs/287892912 I would like to pair for few of them. Can we pair ?

jrgns commented 7 years ago

Fixed in PR #6