search

Eagles-DevOps / MiniTwit

2 stars 2 forks source link

Docker compose pipeline for PR #144

Closed Hopeberg closed 8 months ago

Hopeberg commented 8 months ago

45

Co-authored by: ChatGPT

Romes8 commented 8 months ago

I would slightly adjust this since when the issue was created we did not have any CI/CD pipeline in place.

What docker-compose is doing for us it spins up the server and runs tests on them which allows us to see how app is doing. With this in mind I think it could be more beneficial if we can trigger this action manually when we need and on what ever branch we need. This I think would be more beneficial.

Since now when we push to main we have already a CI/CD pipeline in place where tests get also triggered. So i don't think we need to also run this IMO.

Hopeberg commented 8 months ago

We can hear @rasmus-bn what he had in mind with the issue today

rasmus-bn commented 8 months ago

Yes I think this issue is no longer relevant since we have already have a PR running. Sorry I should have cleaned that up.