search

EangJS / pe

0 stars 0 forks source link

Inaccurate error message #4

Open EangJS opened 1 year ago

EangJS commented 1 year ago

Bug title

Large Integer is an invalid integer

Description of Bug

I have a very heavy pet. I want to add a large weight. However, the error produced says that my very large weight (integer) is an invalid integer which is inaccurate

Steps to reproduce

  1. edit-stat 0 Weight 130000000000000000000000000000000000000000000

image.png

Expected

A more accurate message telling the user how to resolve the issue. Such as input is invalid, try using a smaller integer

Actual

ERROR: Input should be an integer

Inaccurate message that does not tell the user how to solve the issue

Reason for Severity

Low: May cause some issues in resolving the error especially for inexperienced users.

soc-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Input big number for add-stat value

When I give a very big number, both negative and positive, the program tells me to give an integer although the value is already an integer

image.png

[original: nus-cs2113-AY2223S2/pe-interim#2449] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Buggy program behaviour is caused by extreme user behaviour.

Bug is caused by integer overflow. Values between -2,147,483,648 and 2,147,483,647 (min and max values of type int) will result in expected behaviour.

Valid negative values and zero throws the following error:

ERROR: Integer provided should be above 0

Valid non-zero positive values will successfully update the stat.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Extreme user behaviour is of no means to reject the bug. response.Rejected: What tester treated as a bug is in fact the expected and correct behavior (from the user's point of view), or the tester was mistaken in some other way. For example, in CS2040 would you reject a testcase in kattis and give up on getting AC if the test case is an extreme one? If this were marked as response.NotInScope, it would be understandable. Large integers can be caught by checking if the numerical portion of the string contains solely numbers which seems doable. Hence, no reason for this bug to be rejected.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]