EarendelDevelopers / factorio-mods

This is a public repository for tracking issues with Earendel's factorio mods.
18 stars 3 forks source link

Crash when dying after spaceship built in vault #240

Closed BurninSun closed 1 year ago

BurninSun commented 2 years ago

Its possible to build a spaceship inside a vault which is inoperable as expected but then when the player dies, a call is made to Respawn.get_options(player), which loops through global.spaceships and calls spaceship_zone = Zone.from_surface(Spaceship.get_current_surface(spaceship)). Spaceship.get_current_surface(spaceship) goes on to call Spaceship.get_own_surface(spaceship) then return game.get_surface("spaceship-"..spaceship.index) which crashes due to the spaceship built earlier being in the vault.

image