search

EarendelDevelopers / factorio-mods

This is a public repository for tracking issues with Earendel's factorio mods.
19 stars 3 forks source link

[AAI Loaders] Entity Order #327

Closed KiwiHawk closed 10 months ago

KiwiHawk commented 10 months ago

Request: Please don't set order property on Loader entities. Delete loaders.lua:107

If order is not specified on an entity and that entity has an object to place it, the entity's order is set to "z-"..item.order. I asked Bilka why this functionality exists. They didn't know but requested that I create a documentation request. https://forums.factorio.com/viewtopic.php?f=233&t=109705

Entity order is used by helper mods such as Helmod (pictured below) as well as the the vanilla GUI to select an upgrade.

As the loader entities do have an order string set, and it doesn't include the "z-" prefix, they are sorting differently to their related items. They will always be sorted first as other entity's order begins with "z-".

In game, I can see the order of the yellow tier loader is "d[loader]-a01[aai-loader]". If I overwrite the entity's order, setting it to nil, then in game I can see it's order will be "z-d[loader]-a01[aai-loader]".

image

Background: I've taken over maintenance of Bob's Mods. I'm working on adding AAI Loader to support to Bob's Logistics mod. Screenshots are from my work in progress.

After setting entity.order = nil, it looks like this: image

https://github.com/modded-factorio/bobsmods/issues/109

Wiwiweb commented 10 months ago

That makes sense to me, thanks.