search

Earlopain / FoxTrove

E6 Upload Helper
GNU General Public License v3.0
6 stars 3 forks source link

Show file type in gallery #123

Closed Tarrgon closed 5 months ago

Tarrgon commented 5 months ago

Shows the file type of each post in the gallery. vglwr8_18636 1

Tarrgon commented 5 months ago

I can't run rubocop for some reason. One sec.

faucetlol commented 5 months ago

I can't run rubocop for some reason. One sec.

Is docker compose run --rm rubocop not working?

Tarrgon commented 5 months ago

Is docker compose run --rm rubocop not working?

No, it isn't. Something about pull access denied. Idk how rubocop works and don't have a lot of experience with docker, so I'm not entirely sure how to fix it.

I'm also not entirely sure what it wants me to do since, to me, using .to_s here just makes the code less readable lol

faucetlol commented 5 months ago

I'm also not entirely sure what it wants me to do since, to me, using .to_s here just makes the code less readable lol

I don't think you need the string interpolation here at all, <%= Marcel::TYPE_EXTS[submission_file.content_type].first.upcase %> should suffice. I'm not too well versed with Ruby either, but that at least doesn't throw up any issues with Rubocop.

Tarrgon commented 5 months ago

You are completely right