search

Earlybyte / aad_oauth

Flutter Azure Active Directory OAuth Package
https://pub.dev/packages/aad_oauth
MIT License
92 stars 186 forks source link

Refactoring: Resolved Dependency Conflicts and enhanced Code Formatting #302

Closed tratum closed 7 months ago

tratum commented 7 months ago

Pull Request Summary

This pull request Updates the versions of the the Android Configurations of both Example and Example_b2c :

tratum commented 7 months ago

If you have time to review @loetsphi and @josemiguelvarela

loetsphi commented 7 months ago

Thank you for your contribution @tratum, but it's better if we leave only these changes:

  • Upgrading Kotlin to version 1.9.22
  • Switching to Gradle version 7.4
  • Updating the Android Gradle Plugin to version 7.3.1

But we think the formatting should be left alone for now, specially the json and xml files.

I also want to thank you for your contribution @tratum. And i agree with @josemiguelvarela, touch as few files as possible on changes and don't mix features and formatting Pull Requests, because its much harder to review when formatting changes are mixed with actual changes. Also the XML and JSON Formatting settings are a personal preference between 2 and 4, the next person touching the project would reapply 2 as intendation again, and unecessarly touch all the project files again.

loetsphi commented 7 months ago

However it is more convenient for you, you can either resolve the issues (e.g. remove formatting changes) directly in this PR or also create a new one with only the necessary changes.

tratum commented 7 months ago

I've made the required changes and have ensured that my most recent commit has been thoroughly tested within the Android build @loetsphi and @josemiguelvarela just to double-check everything.

Side Note