search

Earlybyte / aad_oauth

Flutter Azure Active Directory OAuth Package
https://pub.dev/packages/aad_oauth
MIT License
92 stars 187 forks source link

Add config parameter to hide signup button #338

Open TesteurManiak opened 1 month ago

TesteurManiak commented 1 month ago

To give some context, my company is publishing a mobile app intended for professionals, where users are supposed to get registered through a separate process. Once registered they will be able to connect using their microsoft accounts.

The thing is that the Google Play Store has been rejecting updates to our app because we provide no way of creating an account through the app and they've been refusing our appeals demand because the Microsoft authentication portal displays an account creation button ("No account? Create one!").

For our app to be accepted we would need to be able to specify a config parameter to be able to hide this button, for example:

AadOAuth(
  Config(
    hideSignup: true, // Would default to false.
    // ...
  ),
);

If you think such feature would be relevant to be added to the package, I've got a simple implementation which you can check here: https://github.com/TesteurManiak/aad_oauth/blob/feat/hide-signup-button/lib/request_code.dart#L131-L152

I'd be glad to submit a PR if you're interested.

rajada1 commented 2 days ago

They rejected an app I developed for a company for the same reason, so I responded like this.

I would like to clarify that the app developed is a SaaS (Software as a Service) solution, distributed to a variety of clients. Publishing it in an enterprise app store would not be viable, as the app is intended for different users and is installed directly on each client’s personal devices. This approach better serves the purpose and nature of the product.

TesteurManiak commented 2 days ago

They rejected an app I developed for a company for the same reason, so I responded like this.

I would like to clarify that the app developed is a SaaS (Software as a Service) solution, distributed to a variety of clients. Publishing it in an enterprise app store would not be viable, as the app is intended for different users and is installed directly on each client’s personal devices. This approach better serves the purpose and nature of the product.

This is something that we've tried to explain already, but our appeal still got rejected. It's definitely an issue with Google's reviewer and not the package in itself.