Did Okta modify their HTML?

Earnest-Labs / aws-sts

Generation of AWS STS tokens via SAML authentication.

67 stars 18 forks source link

Did Okta modify their HTML? #13

Open dabest1 opened 7 years ago

dabest1 commented 7 years ago

Updated Nightmare interactions with the web page to reflect what I am seeing. Had to comment out if (hasError) block as it is always failing and also needs a new selector.

bromanko commented 7 years ago

Hi @dabest1. Thanks for contributing. We're not seeing the same behavior on our side. It's possible that the new selector you propose is more universal. However, I'm uncomfortable with commenting out the error handling. Can you amend this PR to include working error handling?

dabest1 commented 7 years ago

I will try to add some error handling. But the original selectors being used by your code are not available for me for some reason. Should it just be a separate branch for people who see the same problem as me?