search

EarthObservation / RVT_py

Relief Visualization Toolbox in Python
Apache License 2.0
26 stars 6 forks source link

Check operations with nan and resampling of pyramids in sky illumination #8

Closed klezaki-geo closed 3 years ago

klezaki-geo commented 3 years ago

I have finally made several tests and came to the following code corrections:

the fill fill_where_nan works ok, so I made no changes regarding it
added resolution = 1 for the slope/aspect estimation
changed standard resampling in sky_illumination to pyramid_scale = 2 and max_pyramid_radius = 20
added a few checks to see if the computed values are at least zero (if not they are in shade and should be zero)