IMBA 7.00 Bug Compilation Issue

[X-TheDark]

Feel free to post anything here if you don't want to make a separate issue or something.

Silencer - this one's mine

• [x] Some sound stuff that's played at the middle of the map;
• [x] Ulti blows speakers, as I feared - use playsoundforclient; (FIXED)

[EdvardasDlugauskas]

Lion

• [x] Mana Drain can be targeted at creeps without mana
• [x] Finger of Death Frog Panic ignores cast duration. This means there is no chance to avoid it for the targeted enemy.
• [x] Mana drain particles are yuuuggee. They are also kinda weird. Not a fan.
• [x] Finger of Death ash trail is bugged, missing direction Low priority, might fix it later.

[Shushishtok]

• [x] Ursa's and Lycan's innate passives are not in the list of innates skills.

[Eiddew]

• [x] Slardar: Seems to gain and lose an ability any time he gets an item.

• [x] Also his Raincloud ability is only mentioned in what it does, not how to get it -- aghs is blank. Buying aghs on Slardar may crash game (untested, likely unrelated)

[Shushishtok]

Abbadon

• [x] Ability layout of 4 skills while he has 5.
• [x] Mist Coil does not show damage. (done)
• [x] Curse of Avernus does not slow the target nor increase allies' move and attack speed (at least not in the UI, though the target didn't look like it was slowed at all) (done)

[Shushishtok]

Axe

• [x] Enemies affected by Berserker's Call do not show bonus attack speed.

• [x] Battle Hunger's debuff ends immediately (instead of fading out) which looks bad visually.

• [x] Battle Hunter doesn't show base damage or % of maximum HP as damage.

• [x] Battle Hunger doesn't describe the amount of units needed to kill to dispel (just says that lasts until the target kills another unit), nor shows the amount of units needed to kill to dispel.

• [x] Counter Helix shows only the base damage, but not how much of Axe strength's is calculated in it.

• [x] Culling Blade shows "speed" (probably movement speed) as a constant, not percentage.

• [x] Axe doesn't heal from Culling Blade as described in the Trello or the infodump. Instead, it seems to add % of Axe's maximum health to the damage, which is not intended.

• [x] Either way, Culling Blade's % of Maximum Health is not shown in the description.

• [x] Culling Blade doesn't show duration, neither before or after purcashing Aghnaim Scepter.

• [x] Axe doesn't have talents of his own: he'll show the talent of the last hero whose talents were hovered on.

• [x] Tooltips are not updated.

[Shushishtok]

Centaur

• [x] Has an ability layout of 4 skills even though he has 5.
• [x] Return's stacking damage block does not work.
• [x] Return works on towers. - intended according to wiki
• [x] Centaur doesn't have talents of his own: he'll show the talents of the last hero whose talents were hovered on.

[Shushishtok]

Lycan

• [x] Doesn't get his innate.
• [x] (Probably) since Lycan doesn't have his innate, the cooldown can't be calculated properly. Either way, we can probably get rid of nettables calculations by using GetModifierStackCount() instead of setting it.
• [x] When using Shapeshift, an error pops because there is no IsServer() block in function modifier_imba_shapeshift_transform:OnCreated() function (line 980).

[Shushishtok]

Skadi

• [x] Purcashing a skadi pops errors.

[Shushishtok]

Magnus

• [x] Mid-Skewer activation should probably have a No Target behavior as it's practically possible to click anywhere to achieve the knockback effect.

  • [x] Skewer does not "heaves" polarized enemies, which means that it ends prematurely and feels weird, especially if there's at least one enemy that was not polarized: that enemy would be heaved, while the other one stays at the location. They should always be heaved, and if Polarized, should be all heaved towards the exact same spot.
  • [x] Using Manta while having Aghnaim Scepter "purges" the passive Empower on Magnus, causing the scepter duration to tick. When the duration ends, it stays there forever, but without the green circle. Casting Empower on self resets the process. This doesn't happen if you have no scepter, by the way. Having only Manta doesn't cause that bug. It also pops errors in the console, line 392.

• [x] Skewer can be cast while rooted.

[Shushishtok]

Night Stalker

• [x] Still has Void icon for his innate (we really gotta find something cool to replace that).

[Shushishtok]

Slardar

• [x] Doesn't explain what is Rain Cloud or how you get it. Should probably add a "Upgradeable by Aghnaim Scepter", with the aghnaim scepter flavor showing up when holding a scepter.
• [x] Towers can be bashed with Bash of the Deep.

[Shushishtok]

Anti Mage

• [x] Descriptions are not updated.

[Shushishtok]

Curseblade, Hellblade

• [x] DISPELLABLE_DEBUFF_LIST is not loaded anywhere (that I could find), which makes the actives fail completely.
• [x] Hellblade's file is missing, game's trying to route it into curseblade's file.

[Shushishtok]

Desolator

• [x] Active particle is probable not being precached (I don't see a precache block), so it is invisible. Still deals damage and applies Desolator as intended

[Shushishtok]

Bloodseeker

• [x] HP bonus indicator from Blood Rite has a weird placement above Bloodseeker - a bit too high, and it sometimes move to the right or to the left of the caster.
• [x] Thirst: Seems like the on-damage bonus only counts when the target is below 75% health. Is it intended?
• [x] Has no scepter upgrade: we wanted to do a scepter that pushes targets away from Blood Rite with Rupture on them, but we didn't in the end.
• [x] I've got some error after killing a hero just as he got hit by Blood Rite, but I can't repeat it. it seems to be very rare and needs extremely precise timing, so I think it's OK.

  
  stack traceback:
  ...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:301: in function <...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:285>
  [VScript] Script Runtime Error: ...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:301: attempt to compare nil with number
  stack traceback:
  ...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:301: in function <...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:285>
  [VScript] Script Runtime Error: ...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:301: attempt to compare nil with number
  stack traceback:
  ...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:301: in function <...465778740.vpk:scripts\vscripts\hero\hero_bloodseeker.lua:285>```

[Shushishtok]

Bounty Hunter

• [x] HeadHunter is not innately assigned.
• [x] Ability layout is for 4 skills even though he has 5.
• [x] Shadow Walk is supposed to ignore channeled spells (TP)
• [x] Add cast range to Shadow Walk that would show the True Sight reveal area.
• [x] Jinada's Shadow Jaunt can be used while rooted.
• [x] My shitty aghanim's scepter double shuriken code bounced back, literally. If the second shuriken is thrown before the first one hits the target, things go haywire.

[Shushishtok]

Drow Ranger

• [x] Doesn't get her innate assigned at game start.
• [x] Frost Arrows animation is replayed over and over when spamming the unit target spell. This is fixed by adding Immediate behavior to the skill.
• [x] Missing her special Frost particle effects

[Shushishtok]

Faceless Void

• [x] Descriptions are not updated, and talents are not named.
• [x] Time Lock has 100% proc at level 1.
• [x] Faceless Void has no animation for Chronosphere.
• [x] While in Chronosphere, a weird animated copy of himself stays at the cast location. This only happens when Faceless Void has Chronocharges when casting.
  • [x] Chronosphere doesn't seem to interrupt Forced Movement of enemies, allowing Force Staff/Hurrican Pike to move units out of the Chronosphere. (wiki says it shouldn't happen)
• [x] Chronosphere doesn't seem to provide Flying vision in its area of effect.
• [x] Time Walk can be used while rooted.

[Shushishtok]

Juggernaut

• [x] When using Blade Fury while Omnislashing, and Omnislash ends, Juggernaut doesn't keep the Blade Fury animation: the particle stays but he restarts his animations normally. Ignored, this isn't important.
• [x] When Juggernaut gets his Aghnaim Scepter, Omnislash doesn't show how many slashes do you actually get (need to look at base value and add +3 to it, hard math for most players)

[Shushishtok]

Mirana

• [x] Sacred Arrow's first damage instance doesn't crit (that code should be on the damagefilter and it isn't)
• [x] Leap doesn't get extra leap distance at night, both server and client sides. Couldn't reproduce, works fine to me.
• [x] Moonlight Shadow doesn't have a cast animation. Seems like she just doesn't have a cast animation for it. Or I'm blind.

[Shushishtok]

Riki

• [x] All skills have 4/3/2/1 (ult has 3/2/1) cooldown.
• [x] All skills have 4 levels (ult has 3).
• [x] Riki's Blink Strike has only 2 damage values: 200 and 555.
• [x] ~~Riki's Blink Strike will not do anything if the target is out of range: might be annoying sometimes if you just want to make Riki run towards it and jump to it, but instead, Riki stays stationary and does nothing. Instead of showing a custom error, it might be better to just make Riki move towards it and try to jump to it normally, if no jump targets were found.~~
• [x] Riki's Blink Strike doesn't seem to slow turn speed of enemies: if it does work properly, then it definitely needs to be increase, as it takes almost no time to rotate yourself to face Riki.
• [x] Cloak and Dagger immediately apply when leveling up the skill instead of having a fade out time.
• [x] Riki has no custom talents in the talent tree.

@zimberzimber the last update have broken the jumps, maybe because the tables are being cleared too fast or something. I couldn't fix, please try as well. All I've done was move everything from CastFilterResult to another function named BeginJumpCheck() - it does exactly the same but for some reason it never manages to return tables. Not clearing the tables actually improves the situation (Riki jumps) but it only works once since tables are not cleared. Tried OnSpellStart and stuff, I gave up. Please try your recursion magic.

[Shushishtok]

Ursa

• [x] Doesn't get his innate skill.
• [x] Fury Swipes work fully on towers.

[Shushishtok]

Bane

• [x] Has an ability layout of 4 while having 5 skills.
• [x] Seems like skill descriptions aren't updated at all, while talents are actually updated. "new" modifiers have no description at all.
• [x] Enfeeble's attribute reduction in descriptions should be with positives (it's a positive reduction..) instead of negatives.
• [x] Bane can't wake himself up from Nightmare.

@fcalife Scepter is broken. I'd like you to take a look, because it's literally your code mixed in with Seinken's. By all means, you can just rewrite the entire scepter section to be more clear.

[Shushishtok]

Dazzle

• [x] Poison Touch: Description shows %movement_speed%% instead of a value.
• [x] Shadow Wave: Bonus Armor doesn't seem to stay for 3 seconds like it's stated.. more like 1.5 seconds.
• [x] Shadow Wave: Doesn't state what is counted as "injured" for armor increase purposes.
• [x] Weave: I think the stack count is unneccesary, but that's my own opinon, not really a bug.

[Shushishtok]

Disruptor

• [x] Disruptor's innate is not assigned at game start.
• [x] Ability layout of 4 skills while he has 5.
• [x] Static Storm: CAPS IN THE SKILL DESCRIPTION (the word "BY").
• [x] Disruptor has no casting-animations at all.
• [x] Static Storm aghnaim upgrade doesn't state that it also mutes.

[Shushishtok]

Jakiro

• [x] Fire Breath and Ice Breath: Description states -10% move slow - I prefer the values to be positives and not negatives. (done)
• [x] Fire Breath and Ice Breath: Jakiro literally can keep going and going and going forever until reaching the target location, without ever stopping. (done)
• [x] Fire Breath: There is no visual effect for a target being hit by Fire Breath. Likewise for Ice Breath. (done)
• [x] Fire Breath and Ice Breath: it seems that Jakiro will break trees much ahead of him, instead of strictly around his flying location (done)
• [x] Ice Path: Targets do not have a particle of being frozen or for being slowed by the path's aftereffects. (done)
• [x] Liquid Fire: Uses normal attack particle (not Liquid Fire's). (done)
• [x] Macrypyre's alt description "jakiro buffs increases..." - should be changed to "jakiro buff durations increases..." (done)

[Shushishtok]

Lich

• [x] His innate is not being assigned to him at game start.

• [x] Ice Armor fully affects towers: I'm not sure it's a bug, might be alright to keep it. Tower briefly freezes after attacking Lich for the amount. However, towers also get stacks of Permafrost when attacking, becomes slowed, and actually suffer from a Frost Nova that deals full damage to them. This shouldn't stay.

• [x] Scepter Frost Nova: mini Chain Frosts are invisible (probably has not been precached).

• [x] Lich doesn't have its infinite jumps talent.

[Shushishtok]

Lion

• [x] Hex's secret Firetoad model doesn't go up in flames - throws "xxxx" insteaded.
• [x] Hex's secret Firetoad sound is not loaded in the soundevent.
• [x] Lion's Mana Drain Aura particle is invisible (probably not precached).
• [x] Lion's Mana Drain particles are huge. This is probably because the "laser" goes to the enemy's feet, while the rest of the drain particle goes to the enemy's hitloc.
• [x] Lion's Mana Drain particles do not follow allies (but follow enemies), and it goes purely to its feet instead to its hitloc.
• [x] Finger of Death: Frog Panic turns the main target to a frog immediately, removing muh skill cup dodge powa.

[Shushishtok]

Necrophos

• [x] Heartstopper Aura: I still insist that the aura particle is too bright and is kinda invisible, and probably should use "stronger" green colors.
• [x] Sadist: Doesn't show the duration in the buff (so you can't really know when it's going to end)
• [x] Reaper's Scythe: Sick enemies have no particle on them to show the sickness: probably should have a status effect at least? maybe light green, to show nausea?

[Shushishtok]

Angelic Alliance

• [x] Can be cast on self (shouldn't be possible)

[Shushishtok]

Tutela Plate

• [x] Doesn't state how much damage block it has. (not Greater Parry's damage reduction)
• [x] Same for Crimson.

[Shushishtok]

Clinkz

• [x] Missing some Searing Arrows special particles.
• [x] Can consume buildings, probably wards as well.

[Shushishtok]

Morbid Mask, MoM, Satanic, Vladimir

• [x] Special attack particle missing, resulting in absolutely no attack particle for ranged heroes.

• [x] Vladmir only: Doesn't heal the attacker, but heals others affected by the aura.

[Shushishtok]

Omniknight

• [x] When Omniknight heals a target with the double purification talent, it seems to give the target 2 stacks of amped heal instead of just one.

[Shushishtok]

Sniper

• [x] Passive range increase doesn't update (refresh) when leveling the ability.
• [x] Scepter Assassination doesn't target creeps.
• [x] Scepter Assassination triggers Take Aim's Aimed Assault.

[Shushishtok]

Closing bug compilation. Remaining bugs are few and are listed on reddit.