EarthSciML / GasChem.jl

Models of gas-phase atmospheric chemistry and related processes
https://gaschem.earthsci.dev/
MIT License
4 stars 4 forks source link

Successfully compose Fast-JX and SuperFast #21

Closed jialinl6 closed 1 year ago

jialinl6 commented 1 year ago

To update the codes of composing Fast-JX and SuperFast. I will update the documentation tomorrow.

codecov-commenter commented 1 year ago

Codecov Report

Merging #21 (0a30893) into main (6005293) will decrease coverage by 63.87%. The diff coverage is 79.44%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main      #21       +/-   ##
===========================================
- Coverage   82.99%   19.13%   -63.87%     
===========================================
  Files           3        9        +6     
  Lines         147      967      +820     
===========================================
+ Hits          122      185       +63     
- Misses         25      782      +757     
Impacted Files Coverage Δ
src/GasChem.jl 100.00% <ø> (ø)
src/SuperFast_notebook.jl 0.00% <0.00%> (ø)
src/Fast-JX.jl 86.04% <86.04%> (-6.55%) :arrow_down:
src/SuperFast.jl 100.00% <100.00%> (ø)
src/compose_fastjx_superfast.jl 100.00% <100.00%> (ø)
src/RateLawUtilFuncs.jl 0.00% <0.00%> (ø)
src/Ratesfunctions.jl 0.00% <0.00%> (ø)
src/Lawfunctions.jl 0.00% <0.00%> (ø)
src/Geoschem.jl 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ctessum commented 1 year ago

Also the final thing that we'll want to do is add some tests for the new code, so that the test coverage (shown above) is back up near 100%

Thanks for your work on this!