Closed jialinl6 closed 1 week ago
The tests on GitHub failed due to an issue with downloading the NEI2016 emission data. However, both the unit tests (Pkg.test()
)and the documentation ran successfully on a local environment.
Composing models · GasChem.jl.pdf
I created a fundamental base model for emissions Emission()
in the /src/emission.jl. This approach was chosen because defining Emission() solely as an extension does not allow for its exportation and use, even after the extension was precompiled. It appears that extensions are better suited for modifying existing functions rather than introducing new ones. Similar situation found here:https://github.com/pebeto/julia_extensions_example
On Saturday, 16-Mar-24 18:30:10 UTC
by Gov4Git dev
uzucyb
Started managing this PR as Gov4Git proposal 43
with initial approval score of 0.000000
.
This project is managed by Gov4Git, a decentralized governance system for collaborative git projects. To participate in governance, install the Gov4Git desktop app.
Attention: Patch coverage is 72.50000%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 97.78%. Comparing base (
683069c
) to head (4aa05c6
).
Files | Patch % | Lines |
---|---|---|
src/emission.jl | 15.38% | 11 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
On Friday, 12-Jul-24 16:24:53 UTC
by Gov4Git dev
5hg3j7
This PR, managed as Gov4Git proposal 43
, has been closed 🎉
The PR approval tally was 0.000000
.
Bounty of 0.000000
credits was donated to the community's matching fund.
Resolved issues:
Rewarded PR reviewers:
Tally breakdown by user:
Fixes #37
Captures https://github.com/EarthSciML/GasChem.jl/issues/37