EarthSciML / GasChem.jl

Models of gas-phase atmospheric chemistry and related processes
https://gaschem.earthsci.dev/
MIT License
4 stars 4 forks source link

Add Emission model as extension #43

Closed jialinl6 closed 1 week ago

jialinl6 commented 4 months ago

Fixes #37

Captures https://github.com/EarthSciML/GasChem.jl/issues/37

jialinl6 commented 4 months ago

The tests on GitHub failed due to an issue with downloading the NEI2016 emission data. However, both the unit tests (Pkg.test())and the documentation ran successfully on a local environment. 417551710393444_ pic Composing models · GasChem.jl.pdf

jialinl6 commented 4 months ago

I created a fundamental base model for emissions Emission() in the /src/emission.jl. This approach was chosen because defining Emission() solely as an extension does not allow for its exportation and use, even after the extension was precompiled. It appears that extensions are better suited for modifying existing functions rather than introducing new ones. Similar situation found here:https://github.com/pebeto/julia_extensions_example

ctessum commented 4 months ago

This project is governed with Gov4Git. Gov4Git notices

On Saturday, 16-Mar-24 18:30:10 UTC by Gov4Git dev

Notice uzucyb

Started managing this PR as Gov4Git proposal 43 with initial approval score of 0.000000.

This project is managed by Gov4Git, a decentralized governance system for collaborative git projects. To participate in governance, install the Gov4Git desktop app.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 72.50000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 97.78%. Comparing base (683069c) to head (4aa05c6).

Files Patch % Lines
src/emission.jl 15.38% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================== - Coverage 99.45% 97.78% -1.67% ========================================== Files 7 9 +2 Lines 547 587 +40 ========================================== + Hits 544 574 +30 - Misses 3 13 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctessum commented 1 week ago

This project is governed with Gov4Git. Gov4Git notices

On Friday, 12-Jul-24 16:24:53 UTC by Gov4Git dev

Notice 5hg3j7

This PR, managed as Gov4Git proposal 43, has been closed 🎉

The PR approval tally was 0.000000.

Bounty of 0.000000 credits was donated to the community's matching fund.

Resolved issues:

Rewarded PR reviewers:

Tally breakdown by user: