Isti minixml

[andrewcooke-isti]

Merge replacement of libxml2 with minixml (files included).

[andrewcooke-isti]

i tried to merge these but master was broken. waiting for dylan to fix.

[smellyfis]

it's been merged

On 30 May 2017 at 15:11, Andrew Cooke (ISTI projects) < notifications@github.com> wrote:

i tried to merge these but master was broken. waiting for dylan to fix.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iris-edu/evalresp/pull/19#issuecomment-304978388, or mute the thread https://github.com/notifications/unsubscribe-auth/AIjOrEsieANamjBV2V_T92dnY0jsadUhks5r_Gn1gaJpZM4NqZXG .

-- Dylan Thies Come on I dare you Derive me crazy

Don't be charitable because you need to be but because you want to be

[andrewcooke-isti]

what's been merged? you've merged xml into master? you've merged a fix? master still has errors for me.

[smellyfis]

I merged a fix for the ck_assert functions in check_log.c what errors are you seeing now?

On 30 May 2017 at 15:24, Andrew Cooke (ISTI projects) < notifications@github.com> wrote:

what's been merged? you've merged xml into master? you've merged a fix? master still has errors for me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iris-edu/evalresp/pull/19#issuecomment-304981679, or mute the thread https://github.com/notifications/unsubscribe-auth/AIjOrHQs7bsxjjf3QtPjdzTufFMZ9ZOVks5r_GzdgaJpZM4NqZXG .

-- Dylan Thies Come on I dare you Derive me crazy

Don't be charitable because you need to be but because you want to be

[andrewcooke-isti]

the ones i posted in the other pull request:

gcc -DHAVE_CONFIG_H -I. -I../..   -I /usr/include/libxml2 -pthread   -I../../src/ -I../../src/log -O0 -Wall -Werror -Wunused-but-set-variable -MT check_log-check_log.o -MD -MP -MF .deps/check_log-check_log.Tpo -c -o check_log-check_log.o `test -f 'check_log.c' || echo './'`check_log.c
check_log.c: In function ‘test_log_2’:
check_log.c:31:5: error: passing argument 1 of ‘_ck_assert_msg’ makes integer from pointer without a cast [-Werror]
     ck_assert( fd = fopen("log_test.txt", "a+"));
     ^
In file included from check_log.c:3:0:
/usr/include/check.h:237:16: note: expected ‘int’ but argument is of type ‘struct FILE *’
 void CK_EXPORT _ck_assert_msg (int result, const char *file,
                ^
cc1: all warnings being treated as errors

[andrewcooke-isti]

and which, incidentally, also appear in the email i sent you about this 4 hours ago.

[smellyfis]

I pushed a change into fix_for_ck_assert can you merge with that and test on your system. I filtered out that error when I was looking at your email from earlier because I knew about the other one and thought it was both. I do not see these errors on my main build system.

On 30 May 2017 at 15:37, Andrew Cooke (ISTI projects) < notifications@github.com> wrote:

and which, incidentally, also appear in the email i sent you about this 4 hours ago.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iris-edu/evalresp/pull/19#issuecomment-304985123, or mute the thread https://github.com/notifications/unsubscribe-auth/AIjOrI4ShF73gaVhA_YsRYqSEbYM94Z3ks5r_G_wgaJpZM4NqZXG .

-- Dylan Thies Come on I dare you Derive me crazy

Don't be charitable because you need to be but because you want to be

[andrewcooke-isti]

thanks. my merge runs tests fine locally now. will test more fully and commit tomorrow.

[andrewcooke-isti]

somewhere ilya is asking for compiler details - i can't find the question on github but see it in an email.

anyway, this is with gcc 4.8.5 on CentOS 7.3.

[andrewcooke-isti]

please don't merge this yet - running the whole test suite on a vm.

[andrewcooke-isti]

ok, only the b62 is failing, which is how it was before. going to click the big green button.