search

EarthScope / evalresp

Evaluates instrument responses in FDSN and derivative formats
GNU Lesser General Public License v3.0
12 stars 2 forks source link

Clean calc_resp, norm_resp #45

Closed andrewcooke-isti closed 7 years ago

andrewcooke-isti commented 7 years ago

If these are in the legacy interface (I think so) then we need to keep the current call, but that should immediately call to a more sane API (which will have log, and likely return error, and take evalresp_options, or at least not char* for options).

And then the code needs cleaning up. Smaller functional units. Whatever else seems obvious.

smellyfis commented 7 years ago

calc_resp is now calculate_response and will return errors.

smellyfis commented 7 years ago

norm_resp with #50 will return an int

andrewcooke-isti commented 7 years ago

i've moved calc_resp (aka calculate_response) back into calc_fctns which lets us make a bunch of things static.