Adding a log when new file is created

EarthScope / slinktool

Other

18 stars 15 forks source link

Adding a log when new file is created #10

Closed jschaeff closed 1 year ago

jschaeff commented 3 years ago

This is a small patch in order to report in the logs when a new data strem file is created. I proposed this patch because it helps us out in order to detect new files creation when inotify is not possible (i.e. when writing on NFS mounted devices).

It would be great to have this patch upstream.

chad-earthscope commented 2 years ago

A couple of questions:

Is the intention of this to get a log entry only when a new file is created? The existing message implies a new file is created but in reality it could be opening an existing file; I imagine you're trying to address that difference.
Would you be OK with the message at verbosity == 1? In the PR the message is printed at verbosity == 0 and that could be a lot of messages in some scenarios.

jschaeff commented 2 years ago

Hi Chad, thank you for watching this. I guess passing it in versosity 1 would do the job on my side. My second commit 39bac46 should write the message only in case of new file creation. The patch is a bit more intrusive, though.

jschaeff commented 1 year ago

Hi Chad, any chance to see this request end up in the main slinktool branch ?