EarthSystemCoG / COG

COG source code
BSD 3-Clause "New" or "Revised" License
8 stars 16 forks source link

Remove dependency on django-pagination #1195

Closed LucaCinquini closed 8 years ago

LucaCinquini commented 8 years ago

Who: Luca

Currently, CoG uses django-pagination every time there are too many objects to be displayed on one page. Unfortunately, django-pagination is 5 years old and not maintained any more. It will not be compatible with django 1.9+ because it uses the request.REQUEST object that will be supported any longer.

We can instead switch CoG to use the Django "Paginator" object.

LucaCinquini commented 8 years ago

The following pages have been updated to use the django Paginator object:

o /cogadmin/projects/ o /cogadmin/users/ o the comments list of any object: _comments.html o /doc/list/PROJECT_SHORT_NAME/ o /projects/PROJECT_SHORT_NAME/forum/ (list of topics for each forum, and list of comments for each topic thread) o /membership/list/all/PROJECT_SHORT_NAME/ o /news/list/PROJECT_SHORT_NAME/ o /post/list/PROJECT_SHORT_NAME/ o /projects/PROJECT_SHORT_NAME/people/ o /signal/list/PROJECT_SHORT_NAME/

Dependency on django-pagination has been removed.

murphysj commented 8 years ago

I made a slight mod to _pagation.html. I replaced # with Number. We may need to tweak the cosmetics of this a bit more. We'll see what C has to say. For now closing.