EarthSystemCoG / COG

COG source code
BSD 3-Clause "New" or "Revised" License
8 stars 16 forks source link

Fix email content of openid reminder #1216

Closed LucaCinquini closed 8 years ago

LucaCinquini commented 8 years ago

Who: Katharina

Currently it sends one email for each OpenID but the number of OpenIDs per email are increasing because the message string is not cleared after it sends the mail. I think this can be confusing for users.

I see two options - both needs modifications in the code: a) send one single OpenID per mail b) send all OpenIDs in one mail

I think option b) is preferable.

murphysj commented 8 years ago

I am not sure I understand the issue here? Is this when folks hit the openid reminder? How is more than one listed in the email?

On Thu, Jan 28, 2016 at 6:08 AM, Luca Cinquini notifications@github.com wrote:

Who: Katharina

Currently it sends one email for each OpenID but the number of OpenIDs per email are increasing because the message string is not cleared after it sends the mail I think this can be confusing for users

I see two options - both needs modifications in the code: a) send one single OpenID per mail b) send all OpenIDs in one mail

I think option b) is preferable

— Reply to this email directly or view it on GitHub https://github.com/EarthSystemCoG/COG/issues/1216.


Sylvia Murphy NESII/CIRES/NOAA Earth System Research Laboratory 325 Broadway, Boulder CO 80305 Time Zone: U.S. Mountain Web: http://www.esrl.noaa.gov/nesii/ Email: sylvia.murphy@noaa.gov Phone: 303-497-7753

LucaCinquini commented 8 years ago

This is because we do not require emails to be unique in the system (on purpose): many accounts can be associated with the same email.

LucaCinquini commented 8 years ago

Now when a user clicks on 'openid reminder', and enter their email, the system looks for ALL accounts at that CoG that are associated with that email, and for their corresponding open ids. It sends a single email to that address that contains all of the username/openid combinations, one per account.

murphysj commented 8 years ago

We will have to test this in production because cu dev does not have an ESGF IdP.

murphysj commented 8 years ago

FYI, I tested this in production after the release and it worked.