search

EarthSystemCoG / COG

COG source code
BSD 3-Clause "New" or "Revised" License
8 stars 16 forks source link

Oauth2 slcs #1401

Closed watucker closed 4 years ago

watucker commented 5 years ago

Adds support for OAuth2 login via a customisable set of providers. Tested successfully in dev against https://slcs.ceda.ac.uk/.

Uses a copy of the ESGFOAuth2 backend from esgf-auth.

LucaCinquini commented 5 years ago

Hi William, is this ready to be merged now? I thought you had some more work to do. Thanks, L

lukaszlacinski commented 5 years ago

The code responsible for creating new CoG accounts has not been tested. Also if I remember correctly some code needs to be added to avoid account creation conflicts between OpenID and OAuth2.

LucaCinquini commented 5 years ago

Ok thanks . Maybe William will let me know if/when/what to merge.

watucker commented 5 years ago

Hi Luca. I threw this up as a PR just in-case we wanted to merge what we had before working on other issues. I've only tested the OAuth2 call-out (and my testing set-up is limited) so I can't speak for any other work that might need doing on the account-creation side of things.

watucker commented 4 years ago

Replaced by https://github.com/ESGF/COG/pull/4