EarthSystemDiagnostics / cpt-picarr

MIT License
1 stars 0 forks source link

Instrument performance #49

Closed twollnik closed 5 years ago

twollnik commented 5 years ago

closes #12

@thomas-muench I already deployed the updated version to the server. Please give it a try and let me know what you think.

This PR introduces a version with minimal device management options. For instance there is no page "manage devices" and devices cannot be named. The serial number (obtained from the file name) is used to identify and select different devices. How important is device management (naming devices, having a page that lists all devices)?

TODO:

thomas-muench commented 5 years ago

Thanks a lot for the work, I like it!

One could improve the visual layout of the plots later and add the output of the RMSD (single number per isotopic species) across all deviations in the selection.

For now, I would prefer to have the device management functionality included because I talked with Thom about it, and he still would like to have a single Cpt-Picarr instance across AWI for both labs (and wants to push this on the higher organizational level...). In this case, one needs to be able to distinguish instruments between the labs, which is easier with meaningful device names.

Keep up the good work!

twollnik commented 5 years ago

Okay, I will work on device management now and (hopefully) send you an update later today.

twollnik commented 5 years ago

@thomas-muench Please let me know if the currently deployed version covers all our requirements.

thomas-muench commented 5 years ago

@twollnik As a first test I added a new device (L2130i-Pdm (HBDS2090)) which worked sucessfully. However, when I then switched to page Instrument performance this new device was not listed as a suggestion when clicking on the Select ... instruments drop-down menu, only after re-loading the server it was there.

twollnik commented 5 years ago

This behaviour is expected. Do you want the update to happen automatically?

Update: I am implementing the automated update.