search

EarthSystemDiagnostics / cpt-picarr

MIT License
1 stars 0 forks source link

show plots only if the data for them exists #63

Closed twollnik closed 4 years ago

twollnik commented 5 years ago

This PR introduces the following behaviour:

If a user clicks a button to construct a plot on the page process data after some data has been processed successfully the plots are only shown, if the data to plot actually exists. So if a user wants to see plots for memory correction, but no memory correction was done, the button will do nothing if clicked.

@thomas-muench I did not yet have the opportunityto test if this really works. Could you please run the app locally (shiny::runApp('R')) and see if the behaviour is as expected?

thomas-muench commented 5 years ago

@twollnik Good work! I ran the app locally and the behaviour is as expected, i.e., just nothing happens when I click on e.g. the button "Memory correction" and hadn't actually applied it before.

I would suggest to add the output of a message to inform the user in these cases (memory correction and drift correction). Otherwise it might be confusing when you click a button and just nothing happens (although, of course, the user should actually know why...). For example, one could modify the description statements like "Memory corrected data: Not available - you have not applied any memory correction.".

thomas-muench commented 4 years ago

Thanks again for the work. To move on, I will merge this PR now and will open an issue to remind us about the suggestion to also include a user message in the case when the requested plotting data is not available.