EarthSystemDiagnostics / piccr

A bundle of R functions to correct and calibrate raw Picarro cavity ring down spectroscopy stable isotope data.
MIT License
1 stars 2 forks source link

Duplicate code in calculateMemoryCoefficients() #44

Closed thomas-muench closed 4 years ago

thomas-muench commented 4 years ago

There seems to be duplicate code in the function calculateMemoryCoefficients():

https://github.com/EarthSystemDiagnostics/piccr/blob/ec85c626bdaeb21fec566c4d507b4c3042153120/R/maths_correctForMemoryEffect.R#L40-L44

Lines 41 and 42 seem to do the same thing here.

@twollnik To be entirely sure (since you wrote this part): can I savely delete the additional row or do I overlook anything?