search

EarthSystemDiagnostics / piccr

A bundle of R functions to correct and calibrate raw Picarro cavity ring down spectroscopy stable isotope data.
MIT License
1 stars 2 forks source link

Fix key retrieval error in Travis CI testing. #46

Closed thomas-muench closed 4 years ago

thomas-muench commented 4 years ago

This code change fixes the key retrieval error which has started to occur upon travis ci testing since Dec 2 2019 (or earliest Nov 30 2019).

@twollnik Should we merge this PR and do we have to permanently keep this fix?

twollnik commented 4 years ago

@thomas-muench I think the reason for the error has nothing to do with us. The most likely scenario is that something has gone wrong with the package provision (e.g. the key expired and the maintainer has not generated a new one). I expect the package maintainer to be on it. So in my opinion we should merge this pr as is and periodically check if the added line is still necessary.

thomas-muench commented 4 years ago

Ok; thanks for the feedback. I will merge the fix in this PR and periodically check its necessity, as you suggest.