EarthSystemDiagnostics / piccr

A bundle of R functions to correct and calibrate raw Picarro cavity ring down spectroscopy stable isotope data.
MIT License
1 stars 2 forks source link

Add acceptance tests #54

Closed thomas-muench closed 4 years ago

thomas-muench commented 4 years ago

This PR does not introduce any updates to the code base, but, equally well important, it adds general acceptance tests, which check that the overall performace of the piccr processing is within acceptable limits, and therefore also remains so. These tests are based on evaluating and comparing the overall RMSD values for a piccr processing run performed on three exemplary real Picarro isotope measurement files.

The new tests include three general acceptance tests and one benchmark test:

All these new tests are being passed; specifically:

This PR closes #8.

thomas-muench commented 4 years ago

Congratulations @twollnik! Here I finally introduced the acceptance tests which show that your new implementation of the piccr package actually performs better than my old original version. I do not know exactly why this is the case, but anyway, hooray!

twollnik commented 4 years ago

Thats awesome!! :)