search

EarthWorksOrg / EarthWorks

Other
3 stars 3 forks source link

inconsistency between cam and cmeps #11

Closed dazlich closed 1 year ago

dazlich commented 1 year ago

The fully-coupled model will not compile anymore when I check out the v1 main branch of EarthWorks. Specifically, it appears that cam is no longer consistent with cmeps. Formerly, cmeps/cesm/nuopc_cap_shared/seq_dry_dep.F90 declared dheff as a rank 1 array. Now dheff is declared a rank 2 array in shr_dry_dep.f90. Our cam/src/chemistry/mozart/mo_neu_wetdep.F90 uses dheff as a rank-1 array. ESCOMP/CAM cam_development branch uses dheff as a rank-2 array.

Our develop branch of cmeps has the older version with the rank-1 array. It's the main branch that has got ahead of CAM.

gdicker1 commented 1 year ago

@dazlich does this issue still apply after merging PR #14?

dazlich commented 1 year ago

No, that takes care of it.

Don

On Jun 28, 2023, at 7:32 PM, gdicker1 @.***> wrote:

Caution: EXTERNAL Sender

@dazlichhttps://github.com/dazlich does this issue still apply after merging PR #14https://github.com/EarthWorksOrg/EarthWorks/pull/14?

— Reply to this email directly, view it on GitHubhttps://github.com/EarthWorksOrg/EarthWorks/issues/11#issuecomment-1612306655, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADS3XWBBCUCRYFAN2RT3MNTXNTLMPANCNFSM6AAAAAAV7GPMRY. You are receiving this because you were mentioned.Message ID: @.***>