search

EarthWorksOrg / EarthWorks

Other
3 stars 3 forks source link

Ensure use of EarthWorksOrgs externals for develop branch #2

Closed gdicker1 closed 1 year ago

gdicker1 commented 1 year ago

This avoids any mishaps due to personal ownership of codebases and hopefully consolidates where work occurs. Externals affected by this are CCS_Configs, CMEPS, CAM, CIME, MPAS-Ocean, MPAS-SeaIce, and MPAS-Framework.

gdicker1 commented 1 year ago

For each of CCS_Configs, CAM, CMEPS, and CIME I confirmed that the same commit hashes exist on the earthworks branch for the EarthWorksOrg version as existed on the gdicker1 version. For MPAS-Ocean, MPAS-SeaIce, and MPAS-Framework I was also able to confirm the commits are the same on the main branch between the EarthWorksOrg versions and the dazlich versions.

Thus, no code change is introduced in this pull request only modifying external URLs.

mgduda commented 1 year ago

This seems like a good idea. Just to make sure I understand the general strategy: whenever EarthWorks needs to make modifications to an external, those modifications will reside in an EarthWorksOrg fork of that external; and if externals can be used as-is from their original repositories, we don't need to create EarthWorksOrg forks, right?

gdicker1 commented 1 year ago

@mgduda just to follow up with info from our in-person discussions: this matches with how I understand things. The only thing to add is that depending on the modification it may get submitted to the upstream (original repository) as well. Also, it may even be the case that all of our changes for an external gets accepted by the upstream, and thus we don't need the EarthWorksOrg fork anymore.