Fix "Multiple definition" Error for GPU builds of compsets using multiple MPAS cores

EarthWorksOrg / EarthWorks

Other

3 stars 2 forks source link

Fix "Multiple definition" Error for GPU builds of compsets using multiple MPAS cores #39

Closed gdicker1 closed 5 months ago

gdicker1 commented 5 months ago

This PR incorporates changes in mpas-framework to the module names and changes to the buildlib scripts of mpas-ocean and mpas-seaice. All modules in mpas-framework source files begin with MPASAOS which the buidlib scripts replace (with mpass for mpas-seaice and mpaso for mpas-ocean) to create unique files and module names for mpas-seaice and mpas-ocean to use in their builds.

Fixes #36 but preserves compilation of 3 copies of "shared MPAS framework" routines.

gdicker1 commented 5 months ago

Currently a draft because the tags referenced in https://github.com/EarthWorksOrg/EarthWorks/commit/24948add9992ac1bb3c1c8880faf2ab9002cdb7a haven't been pushed yet.

gdicker1 commented 5 months ago

The tags currently exist. It is possible to get this branch, run checkout_externals, and test these changes. Recommended test is to attempt a case on GPUs using the FullyCoupled compset.