Not working in snapshot versions

Earthcomputer / EnchantmentCracker

Cracking the XP seed in Minecraft and choosing your enchantments

MIT License

1.04k stars 91 forks source link

Not working in snapshot versions #152

Closed Spaghet4Life closed 4 years ago

Spaghet4Life commented 4 years ago

I know this is probably to be expected but I didn't see an issue about this so I'll open one.

Spaghet4Life commented 4 years ago

Also I have no clue how to add labels

Earthcomputer commented 4 years ago

Duplicate of #133, although the necessary changes for 1.16 so far have been implemented, and you can use it if you compile from source. I only create releases for full releases, and I explain the reasoning in the linked issue.

Adding labels is something most users don't have permission to do, sorry!

Spaghet4Life commented 4 years ago

How can I compile from source?

Earthcomputer commented 4 years ago

Follow the "building from source" section in the readme.

Spaghet4Life commented 4 years ago

This is what happens

Earthcomputer commented 4 years ago

Oh, right, I need to update gradle then. In the mean time, you can compile it with jdk8 by first running set JAVA_HOME=C:\path\to\your\jdk8\installation, which will temporarily change your default Java version until you close cmd.

Spaghet4Life commented 4 years ago

I set the JAVA_HOME, but how do I compile?

Earthcomputer commented 4 years ago

Just run gradlew build

Spaghet4Life commented 4 years ago

Again, the same "Could not determine java version from '14'" error

Earthcomputer commented 4 years ago

Ah, sod it! I updated Gradle for you, so it should now recognize your Java 14 installation.

Run git pull to get the up-to-date version of the repository.
Try gradlew build again after that.

Spaghet4Life commented 4 years ago

Ok, I built it, thanks and sorry for bothering you

Spaghet4Life commented 4 years ago

Also, I've done this 3 times now, there's always something missing from what I've tried to enchant.

Spaghet4Life commented 4 years ago

In particular Looting and Sweeping Edge were missing on both of the 2 swords (1 netherite and 1 diamond) that I enchanted.

Earthcomputer commented 4 years ago

It might be better to create a new issue to track that, and I will try and reproduce your issue, thanks

Earthcomputer commented 4 years ago

@TheDarkAndroid you must have done something wrong. I just tried it out on the latest snapshot (20w15a), and succesfully enchanted both a netherite and diamond sword with looting 3, sweeping edge 3 and sharpness 4.

Spaghet4Life commented 4 years ago

Hmm, I'll have to try again