search

Earthcomputer / EnchantmentCracker

Cracking the XP seed in Minecraft and choosing your enchantments
MIT License
1.04k stars 91 forks source link

Help wanted: The enchant cracker keeps crashing after I checked the 15 bookshelves value #189

Open 6TNTYeeter9 opened 4 years ago

6TNTYeeter9 commented 4 years ago

So I tried to inserted all the values but it kept crashing every time when I check for the 15 bookshelves value within a second. What can I do to stop it from crashing? The runtime parameter of my java is 2GB. image enchcracker.log

pbolduc commented 4 years ago

Just confirm that you have adjusted the heap size parameters correctly. See: https://javarevisited.blogspot.com/2011/05/java-heap-space-memory-size-jvm.html

The JVM expands Heap in Java somewhere near to Maximum Heap Size specified by -Xmx and if there is no more memory left for creating new objects in java heap, JVM throws java.lang.OutOfMemoryError and your application die.

Alternately, you could run 64-bit version and give it more memory. The app uses multiple threads based on the number of CPUs you have. Each one allocates memory.

Hexicube commented 4 years ago

The problem is, ironically, that you have a good CPU. Forcing it to see my own CPU as a 56-core it ended up allocating almost 3GB, compared with 1.5GB for the 6 cores it actually has.

I'll make a tweak to the per-thread list size that factors this in, which should fix the issue.