search

Earthcomputer / clientcommands

Adds useful client-side commands
Other
1.04k stars 113 forks source link

/cfish on patched paper server #525

Open sofianedjerbi opened 1 year ago

sofianedjerbi commented 1 year ago

Hello,

I wanted to "patch" paper to be able to run ccrackrng cenchant and cfish. Removing the following patch don't seem to work on cfish (but ccrackrng works fine): https://github.com/PaperMC/Paper/blob/df8d28a450fe391b9f0c2dc4a64543cf9b84266f/patches/server/0070-Use-a-Shared-Random-for-Entities.patch What other aspect of the FishingHookEntity does clientcommands rely on ? So I can "patch" paper to support it again 🤔

Earthcomputer commented 1 year ago

It's surprising to me that cfish doesn't work for you after removing that patch. clientcommands relies on the exact movement of the fishing hook, all its random calls (except bobbing on the surface because the hook isn't allowed to go above the surface), the time at which the fish bites and the loot table logic.

sofianedjerbi commented 1 year ago

Okay, I'll look into it. (No output, it just fail) It works fine on CB/spigot